fix: correct invalid Liquid syntax in image.html include#821
Merged
MakisH merged 2 commits intoprecice:masterfrom Mar 2, 2026
Merged
fix: correct invalid Liquid syntax in image.html include#821MakisH merged 2 commits intoprecice:masterfrom
MakisH merged 2 commits intoprecice:masterfrom
Conversation
Contributor
|
@MakisH LGTM! |
Contributor
|
@praaatap solid PR. please rebase and update the branch for merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This Pull Request resolves a common syntax error in the [_includes/image.html] file, where Liquid output tags were mistakenly placed inside logic tags. It also introduces minor security hardening to external links.
Changes Made
{{ }}tags inside{% if %}tags. In Liquid syntax, logic tags are evaluated directly from the context, and placing output tags inside them is actually incorrect syntax that may cause build warnings or unexpected rendering issues.rel="noopener noreferrer"to external links withtarget="_blank". This is a current best practice for web security to prevent tab-nabbing and improve user privacy when leaving the documentation site.How to test
bundle exec jekyll serve