Skip to content

fix: correct invalid Liquid syntax in image.html include#821

Merged
MakisH merged 2 commits intoprecice:masterfrom
praaatap:fix/liquid-html-image
Mar 2, 2026
Merged

fix: correct invalid Liquid syntax in image.html include#821
MakisH merged 2 commits intoprecice:masterfrom
praaatap:fix/liquid-html-image

Conversation

@praaatap
Copy link
Contributor

Description

This Pull Request resolves a common syntax error in the [_includes/image.html] file, where Liquid output tags were mistakenly placed inside logic tags. It also introduces minor security hardening to external links.

Changes Made

  • Corrected Liquid Syntax: Stripped the nested {{ }} tags inside {% if %} tags. In Liquid syntax, logic tags are evaluated directly from the context, and placing output tags inside them is actually incorrect syntax that may cause build warnings or unexpected rendering issues.
  • Security Hardening: Added rel="noopener noreferrer" to external links with target="_blank". This is a current best practice for web security to prevent tab-nabbing and improve user privacy when leaving the documentation site.

How to test

  1. Build the Jekyll site locally: bundle exec jekyll serve
  2. Open any page with the [image.html]include (such as the 404 page).
  3. Verify that the image URLs are still properly rendered.

@MakisH MakisH added technical Technical issues on the website GSoC Contributed in the context of the Google Summer of Code labels Mar 2, 2026
@hanzalahwaheed
Copy link
Contributor

@MakisH LGTM!

@hanzalahwaheed
Copy link
Contributor

@praaatap solid PR. please rebase and update the branch for merging.

Copy link
Member

@MakisH MakisH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MakisH MakisH merged commit 717f2b8 into precice:master Mar 2, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

GSoC Contributed in the context of the Google Summer of Code technical Technical issues on the website

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants