Skip to content

fix: resolve implicit global variables in github-queries.js #816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
praaatap wants to merge 3 commits into from
Closed

fix: resolve implicit global variables in github-queries.js #816

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f597b9f
fix: resolve implicit global variables in github-queries.js
praaatap Feb 26, 2026
419e0ab
added semicolon
praaatap Mar 14, 2026
79d0bc6
Merge branch 'master' into fix/github-queries-globals
praaatap Mar 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 10 additions & 37 deletions js/github-queries.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
// Get the updated field of an entry of the feed and format it like "Jan 1, 1970"
function formatDate(updated) {
// Extract the date and create a Date object
var date = new Date(updated);
const date = new Date(updated);

// Names for the months (we do not need an external library just for this)
var monthNames = ["Jan", "Feb", "Mar", "Apr", "May", "Jun", "Jul", "Aug", "Sep", "Oct", "Nov", "Dec"];
Expand All @@ -27,23 +27,12 @@ var github_api_endpoint = 'https://api.github.com/repos/precice/precice/releases
fetch(github_api_endpoint).then(function(response) {
if (response.ok) {
response.json().then(function(data) {
var tag = data[0].name;
var published_at = data[0].published_at;
var url = data[0].html_url;

var link = document.createElement('a');
link.setAttribute('href', url);
link.className = 'btn btn-secondary no-icon action-button';
link.setAttribute('role', 'button');
link.setAttribute('target', '_blank');
link.setAttribute('rel', 'noopener noreferrer');
link.appendChild(document.createTextNode('Latest ' + tag + ' (' + formatDate(published_at) + ') \u00A0'));
var icon = document.createElement('i');
icon.className = 'fas fa-download';
link.appendChild(icon);

var container = document.getElementById('latest-release');
container.replaceChildren(link);
const tag = data[0].name;
const published_at = data[0].published_at;
const url = data[0].html_url;
// Format the text, which contains the link, the title, and the date.
var text = '<a href="' + url + '" class="btn btn-secondary no-icon action-button" role="button" target="_blank" rel="noopener noreferrer">Latest ' + tag + ' (' + formatDate(published_at) + ') &nbsp;<i class="fas fa-download"></i></a>';
document.getElementById('latest-release').innerHTML = text;
});
}
else throw new Error("Problem with fetching releases");
Expand All @@ -65,25 +54,9 @@ document.addEventListener("DOMContentLoaded", function() {
fetch(github_api_endpoint).then(function(response) {
if (response.ok) {
response.json().then(function(data) {
var count = data.stargazers_count;

var link = document.createElement('a');
link.setAttribute('href', 'https://github.com/precice/precice/');
link.className = 'btn btn-default no-icon action-button';
link.setAttribute('role', 'button');
link.setAttribute('target', '_blank');
link.setAttribute('rel', 'noopener noreferrer');
link.appendChild(document.createTextNode('Star on GitHub \u00A0'));
var icon = document.createElement('i');
icon.className = 'fas fa-star';
link.appendChild(icon);
var span = document.createElement('span');
span.id = 'stargazers';
span.textContent = ' ' + count;
link.appendChild(span);

var container = document.getElementById('github-button');
container.replaceChildren(link);
const count = data.stargazers_count;
var text = '<a href="https://github.com/precice/precice/" class="btn btn-default no-icon action-button" role="button" target="_blank" rel="noopener noreferrer">Star on GitHub &nbsp;<i class="fas fa-star"></i><span id="stargazers"> ' + count + '</span></a>';
document.getElementById('github-button').innerHTML = text;
});
}
else throw new Error("Problem with fetching stargazers");
Expand Down