fix: resolve implicit global variables in github-queries.js#816
Open
praaatap wants to merge 1 commit intoprecice:masterfrom
Open
fix: resolve implicit global variables in github-queries.js#816praaatap wants to merge 1 commit intoprecice:masterfrom
praaatap wants to merge 1 commit intoprecice:masterfrom
Conversation
MakisH
added
GSoC
| url = data[0].html_url | ||
| const tag = data[0].name; | ||
| const published_at = data[0].published_at; | ||
| const url = data[0].html_url |
Contributor
There was a problem hiding this comment.
semicolon missing here. I noticed rest of the file uses semicolons at the end. lets follow a common syntax.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a few places where variables were being assigned without an explicit declaration (
let,const, orvar) in [js/github-queries.js]I have refactored these places to use
constbecause these variables are not being reassigned in their scopes.Changes
dateinside the function.countinside the stargazers-fetching closure.Verification