Skip to content

Test: Add a warning for when targeting attributes are truncated #4192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
osulzhenko merged 2 commits into from
Sep 29, 2025
Merged

Test: Add a warning for when targeting attributes are truncated #4192

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
293f250
Test: Add a warning for when targeting attributes are truncated
osulzhenko Sep 16, 2025
ecce6aa
Update after review
osulzhenko Sep 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/test/groovy/org/prebid/server/functional/testcontainers/PbsConfig.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,5 +145,9 @@ LIMIT 1
"currency-converter.external-rates.refresh-period-ms" : "900000"]
}

static Map<String,String> getTargetingConfig() {
["settings.targeting.truncate-attr-chars": '255']
}

private PbsConfig() {}
}
1 change: 1 addition & 0 deletions ...groovy/org/prebid/server/functional/testcontainers/container/PrebidServerContainer.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ class PrebidServerContainer extends GenericContainer<PrebidServerContainer> {
<< PbsConfig.bidderAliasConfig
<< PbsConfig.prebidCacheConfig
<< PbsConfig.mySqlConfig
<< PbsConfig.targetingConfig
withConfig(commonConfig)
withConfig(customConfig)
}
Expand Down
9 changes: 4 additions & 5 deletions src/test/groovy/org/prebid/server/functional/tests/CacheSpec.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ class CacheSpec extends BaseSpec {
private static final String PBS_API_HEADER = 'x-pbc-api-key'
private static final Integer MAX_DATACENTER_REGION_LENGTH = 4
private static final Integer DEFAULT_UUID_LENGTH = 36
private static final Integer TARGETING_PARAM_NAME_MAX_LENGTH = 20

private static final String XML_CREATIVE_SIZE_ACCOUNT_METRIC = "account.%s.prebid_cache.creative_size.xml"
private static final String JSON_CREATIVE_SIZE_ACCOUNT_METRIC = "account.%s.prebid_cache.creative_size.json"
Expand Down Expand Up @@ -612,8 +611,8 @@ class CacheSpec extends BaseSpec {
it.get("hb_cache_id_generic")
it.get("hb_cache_path") == CACHE_PATH
it.get("hb_cache_host") == CACHE_HOST
it.get("hb_cache_path_generic".substring(0, TARGETING_PARAM_NAME_MAX_LENGTH)) == CACHE_PATH
it.get("hb_cache_host_generic".substring(0, TARGETING_PARAM_NAME_MAX_LENGTH)) == CACHE_HOST
it.get("hb_cache_path_generic") == CACHE_PATH
it.get("hb_cache_host_generic") == CACHE_HOST
}

and: "Debug should contain http call"
Expand Down Expand Up @@ -648,8 +647,8 @@ class CacheSpec extends BaseSpec {
it.get("hb_cache_id_generic")
it.get("hb_cache_path") == INTERNAL_CACHE_PATH
it.get("hb_cache_host") == networkServiceContainer.hostAndPort.toString()
it.get("hb_cache_path_generic".substring(0, TARGETING_PARAM_NAME_MAX_LENGTH)) == INTERNAL_CACHE_PATH
it.get("hb_cache_host_generic".substring(0, TARGETING_PARAM_NAME_MAX_LENGTH)) == networkServiceContainer.hostAndPort.toString()
it.get("hb_cache_path_generic") == INTERNAL_CACHE_PATH
it.get("hb_cache_host_generic") == networkServiceContainer.hostAndPort.toString()
}

and: "Debug should contain http call"
Expand Down
Loading