Test: Add a warning for when targeting attributes are truncated #4192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osulzhenko
added
do not merge
osulzhenko
changed the title
osulzhenko
changed the base branch from
master
to
targeting-truncating-keys-message
marki1an
requested changes
Sep 26, 2025
src/test/groovy/org/prebid/server/functional/testcontainers/PbsConfig.groovy
Show resolved
Hide resolved
| private static final Integer SUBORDINATE_RANK = 2 | ||
| private static final Integer DEFAULT_TRUNCATE_CHARS = 20 | ||
| private static final Integer EXTENDED_TRUNCATE_CHARS = PbsConfig.targetingConfig.get('settings.targeting.truncate-attr-chars').toInteger() | ||
| private static final Map<String, String> DEFAULT_TARGETING_CONFIG = ['settings.targeting.truncate-attr-chars': null] as Map |
Collaborator
There was a problem hiding this comment.
Please use double quotes or single quotes
It isn't default, rather empty or undefined
| def ampResponse = pbsWithDefaultTargetingLength.sendAmpRequest(ampRequest) | ||
|
|
||
| then: "Amp response should contain warning" | ||
| assert ampResponse.ext?.warnings[TARGETING]*.message == ["Key prefix value is dropped to default. " + |
Collaborator
There was a problem hiding this comment.
Can be constant with placeholder
| def accountConfig = new AccountConfig(status: ACTIVE, auction: accountAuctionConfig) | ||
| def pbsService = pbsServiceFactory.getService( | ||
| ["settings.default-account-config": encode(accountConfig)]) | ||
| def pbsConfig = ["settings.default-account-config": encode(accountConfig)] |
Collaborator
There was a problem hiding this comment.
Add and block between creating of account and creating pbs container
marki1an
approved these changes
Sep 29, 2025
osulzhenko
deleted the
functional-tests/targeting-truncating-keys-message
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Type of changes
✨ What's the context?
What's the context for the changes?
🧠 Rationale behind the change
Why did you choose to make these changes? Were there any trade-offs you had to consider?
🔎 New Bid Adapter Checklist
🧪 Test plan
How do you know the changes are safe to ship to production?
🏎 Quality check