-
Notifications
You must be signed in to change notification settings - Fork 224
OpenX Adapter: Set buyer exts fields in bid.ext.prebid.meta
#4171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenX Adapter: Set buyer exts fields in bid.ext.prebid.meta
#4171
Conversation
AntoxaAntoxic
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please mention a corresponding PR link for PBS Go if any. Thanks!
src/main/java/org/prebid/server/bidder/openx/proto/OpenxBidExt.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/bidder/openx/proto/OpenxBidExt.java
Outdated
Show resolved
Hide resolved
src/test/java/org/prebid/server/bidder/openx/OpenxBidderTest.java
Outdated
Show resolved
Hide resolved
| @ParameterizedTest | ||
| @MethodSource("bidWithExtTestCases") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ParameterizedTest are prohibited in the repository, please split it into separate unit tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also the tests should be above private static factory methods, please place the tests in the correct order
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed - tests are separated and moved above private static factory methods.
🔧 Type of changes
✨ What's the context?
We want to start returning
advertiserId,networkIdandbrandIdinbid.ext.prebid.metaas we already do in prebid.js adapter.Corresponding PR for PBS Go: prebid/prebid-server#4507
🧠 Rationale behind the change
Why did you choose to make these changes? Were there any trade-offs you had to consider?
🔎 New Bid Adapter Checklist
🧪 Test plan
How do you know the changes are safe to ship to production?
🏎 Quality check