Skip to content

Multiple Bidder Codes #3855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
CTMBNara merged 9 commits into from
Apr 16, 2025
Merged

Multiple Bidder Codes #3855

CTMBNara merged 9 commits into from
Apr 16, 2025

Conversation

@AntoxaAntoxic
Copy link
Collaborator

@AntoxaAntoxic AntoxaAntoxic commented Mar 21, 2025 •
edited by Net-burst
Loading

🔧 Type of changes

  • new bid adapter
  • bid adapter update
  • new feature
  • new analytics adapter
  • new module
  • module update
  • bugfix
  • documentation
  • configuration
  • dependency update
  • tech debt (test coverage, refactorings, etc.)

✨ What's the context?

prebid/prebid-server#3363

🧠 Rationale behind the change

Why did you choose to make these changes? Were there any trade-offs you had to consider?

🔎 New Bid Adapter Checklist

  • verify email contact works
  • NO fully dynamic hostnames
  • geographic host parameters are NOT required
  • direct use of HTTP is prohibited - implement an existing Bidder interface that will do all the job
  • if the ORTB is just forwarded to the endpoint, use the generic adapter - define the new adapter as the alias of the generic adapter
  • cover an adapter configuration with an integration test

🧪 Test plan

How do you know the changes are safe to ship to production?

🏎 Quality check

  • Are your changes following our code style guidelines?
  • Are there any breaking changes in your code?
  • Does your test coverage exceed 90%?
  • Are there any erroneous console logs, debuggers or leftover code in your changes?

@AntoxaAntoxic AntoxaAntoxic added do not merge Not the time for merging yet do not port labels Mar 21, 2025
@AntoxaAntoxic AntoxaAntoxic self-assigned this Mar 21, 2025
@AntoxaAntoxic AntoxaAntoxic requested a review from CTMBNara March 26, 2025 10:59
@AntoxaAntoxic AntoxaAntoxic removed the do not merge Not the time for merging yet label Apr 10, 2025
@AntoxaAntoxic
Merge remote-tracking branch 'refs/remotes/origin/master' into multip…
c9951ad 
…le-bidder-codes

# Conflicts:
#	src/main/java/org/prebid/server/auction/BidResponseCreator.java
@AntoxaAntoxic
Fix tests
7a7764e
CTMBNara
CTMBNara requested changes Apr 10, 2025
View reviewed changes
@osulzhenko osulzhenko requested a review from CTMBNara April 14, 2025 07:13
CTMBNara
CTMBNara requested changes Apr 14, 2025
View reviewed changes
@CTMBNara CTMBNara merged commit 8e8a301 into master Apr 16, 2025
8 checks passed
@CTMBNara CTMBNara deleted the multiple-bidder-codes branch April 16, 2025 09:34
@EmilNadimanov EmilNadimanov mentioned this pull request Apr 16, 2025
Merged
21 tasks
@Net-burst
Copy link
Collaborator

Net-burst commented Apr 24, 2025

This PR is related to this Prebid issue: prebid/prebid-server#3363
@AntoxaAntoxic please make sure that you attach the original issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CTMBNara CTMBNara CTMBNara approved these changes

Assignees

@AntoxaAntoxic AntoxaAntoxic

Labels

do not port

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@AntoxaAntoxic @Net-burst @CTMBNara @marki1an