-
Notifications
You must be signed in to change notification settings - Fork 224
Port FeedAd: New Adapter #3869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port FeedAd: New Adapter #3869
Conversation
src/main/java/org/prebid/server/proto/openrtb/ext/request/feedad/ExtImpFeedAd.java
Outdated
Show resolved
Hide resolved
|
Hi folks, The functional test seems unrelated to this port. |
|
Functional test failure is due to a flaky test, so it can be ignored for the purpose of this PR. |
src/test/java/org/prebid/server/bidder/feedad/FeedAdBidderTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/prebid/server/bidder/feedad/FeedAdBidderTest.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/proto/openrtb/ext/request/feedad/ExtImpFeedAd.java
Outdated
Show resolved
Hide resolved
src/test/java/org/prebid/server/bidder/feedad/FeedAdBidderTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/prebid/server/bidder/feedad/FeedAdBidderTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/prebid/server/bidder/feedad/FeedAdBidderTest.java
Outdated
Show resolved
Hide resolved
|
@EmilNadimanov failed IT test |
|
Huh, I didn't make any changes to the fixtures, the test or the Bidder Adapter. And it works locally. I will take a look, in the meantime I've updated the branch to be up to date with upstream master |
🔧 Type of changes
✨ What's the context?
#3718 Porting the FeedAd Bidder Adapter
🧠 Rationale behind the change
Keeping prebid-server-java up to date
🔎 New Bid Adapter Checklist
🧪 Test plan
How do you know the changes are safe to ship to production?
Unit tests + an integration test for the happy case
🏎 Quality check