Skip to content

Conversation

@EmilNadimanov
Copy link
Contributor

@EmilNadimanov EmilNadimanov commented Mar 27, 2025

🔧 Type of changes

  • new bid adapter
  • bid adapter update
  • new feature
  • new analytics adapter
  • new module
  • module update
  • bugfix
  • documentation
  • configuration
  • dependency update
  • tech debt (test coverage, refactorings, etc.)

✨ What's the context?

#3718 Porting the FeedAd Bidder Adapter

🧠 Rationale behind the change

Keeping prebid-server-java up to date

🔎 New Bid Adapter Checklist

  • verify email contact works
  • NO fully dynamic hostnames
  • geographic host parameters are NOT required
  • direct use of HTTP is prohibited - implement an existing Bidder interface that will do all the job
  • if the ORTB is just forwarded to the endpoint, use the generic adapter - define the new adapter as the alias of the generic adapter
  • cover an adapter configuration with an integration test

🧪 Test plan

How do you know the changes are safe to ship to production?
Unit tests + an integration test for the happy case

🏎 Quality check

  • Are your changes following our code style guidelines?
  • Are there any breaking changes in your code?
  • Does your test coverage exceed 90%?
  • Are there any erroneous console logs, debuggers or leftover code in your changes?

@muuki88
Copy link
Contributor

muuki88 commented Apr 8, 2025

Hi folks,

The functional test seems unrelated to this port.

[INFO] 
[INFO] Results:
[INFO] 
Error:  Failures: 
Error:    CcpaAuctionSpec.PBS should recognise 'web' and 'pbjs' as the same channel when privacy.ccpa config is defined in account:295 Condition not satisfied:

bidderRequests.device?.geo == maskGeo(bidRequest)
|              |       |   |  |       |
|              |       |   |  |       org.prebid.server.functional.model.request.auction.BidRequest(id:fa87144d-f3d1-4307-8f86-363a858fdd59, imp:[org.prebid.server.functional.model.request.auction.Imp(id:0fa00a03-b4f6-467e-badb-2945ad22e3e9, banner:org.prebid.server.functional.model.request.auction.Banner(format:[org.prebid.server.functional.model.request.auction.Format(weight:300, height:250)]), ext:org.prebid.server.functional.model.request.auction.ImpExt(prebid:org.prebid.server.functional.model.request.auction.ImpExtPrebid(bidder:org.prebid.server.functional.model.request.auction.Bidder(generic:org.prebid.server.functional.model.bidder.Generic@23d3a475, configuredBidders:[generic]))), bidderName:generic, mediaTypes:[BANNER])], site:org.prebid.server.functional.model.request.auction.Site(page:A7JaW5HIHdzjC8zctMB1, publisher:org.prebid.server.functional.model.request.auction.Publisher(id:1328026267)), device:org.prebid.server.functional.model.request.auction.Device(geo:org.prebid.server.functional.model.request.auction.Geo(lat:79.70198, lon:56.165, accuracy:1370528651, ipservice:1322639745, country:USA, region:ALABAMA, metro:MEJmuz5NAoiacAgpsypK, city:SWGUq2ernv2iosf5sBB4, zip:Qjdo6TuYAPRsssM5ZO2i, utcoffset:1604501213, ext:org.prebid.server.functional.model.request.auction.GeoExt(geoProvider:org.prebid.server.functional.model.request.auction.GeoExtGeoProvider())), ip:43.77.114.227, ipv6:af47:892b:3e98:b49a:a747:bda4:a6c8:aee2), user:org.prebid.server.functional.model.request.auction.User(id:ldn8reih9VVBUZGXbL35, geo:org.prebid.server.functional.model.request.auction.Geo(lat:4.434147, lon:74.97165)), tmax:2500, regs:org.prebid.server.functional.model.request.auction.Regs(gdpr:0, usPrivacy:1YY-), ext:org.prebid.server.functional.model.request.auction.BidRequestExt(prebid:org.prebid.server.functional.model.request.auction.Prebid(debug:ENABLED, channel:org.prebid.server.functional.model.request.auction.Prebid$Channel@413ebdd2)), requestBidders:[generic], requestDistributionChannels:[SITE], accountId:1328026267)
|              |       |   |  org.prebid.server.functional.model.request.auction.Geo(lat:79.7, lon:56.16, country:USA, region:ALABAMA, utcoffset:1604501213)
|              |       |   false
|              |       org.prebid.server.functional.model.request.auction.Geo(lat:79.7, lon:56.17, country:USA, region:ALABAMA, utcoffset:1604501213)
|              org.prebid.server.functional.model.request.auction.Device(geo:org.prebid.server.functional.model.request.auction.Geo(lat:79.7, lon:56.17, country:USA, region:ALABAMA, utcoffset:1604501213), ua:Apache-HttpClient/4.5.14 (Java/21.0.6), ip:43.77.114.0, ipv6:af47:892b:3e98:b400::)
org.prebid.server.functional.model.bidderspecific.BidderRequest(imp:[org.prebid.server.functional.model.bidderspecific.BidderImp(ext:org.prebid.server.functional.model.bidderspecific.BidderImpExt(bidder:org.prebid.server.functional.model.bidder.GeneralBidderAdapter@23d3a475))])

@Net-burst
Copy link
Collaborator

Net-burst commented Apr 8, 2025

Functional test failure is due to a flaky test, so it can be ignored for the purpose of this PR.

@AntoxaAntoxic AntoxaAntoxic linked an issue Apr 10, 2025 that may be closed by this pull request
@AntoxaAntoxic AntoxaAntoxic changed the title Porting FeedAd Adapter from Go Port FeedAd: New Adapter Apr 10, 2025
AntoxaAntoxic
AntoxaAntoxic previously approved these changes Apr 14, 2025
AntoxaAntoxic
AntoxaAntoxic previously approved these changes Apr 14, 2025
@osulzhenko
Copy link
Collaborator

@EmilNadimanov failed IT test

@EmilNadimanov
Copy link
Contributor Author

EmilNadimanov commented Apr 16, 2025

Huh, I didn't make any changes to the fixtures, the test or the Bidder Adapter. And it works locally. I will take a look, in the meantime I've updated the branch to be up to date with upstream master
UPD: ok, it fails locally as well after I pulled the changes from upstream. Working on it.
UPD2: ah, I needed to add meta info with the adapter code to the bid extension because of #3855

@osulzhenko osulzhenko requested a review from CTMBNara April 16, 2025 15:06
@CTMBNara CTMBNara merged commit 6b73664 into prebid:master Apr 17, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Port PR from PBS-Go: New Adapter: FeedAd

6 participants