-
Notifications
You must be signed in to change notification settings - Fork 54
Add blog post for week 33 #1057
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add blog post for week 33 #1057
Conversation
Signed-off-by: Nikola Forró <nforro@redhat.com>
|
Build failed. ❌ pre-commit FAILURE in 1m 16s |
|
What to do with the prettier errors? |
|
taking the ci pre commit changes, wouldn't fix it? |
There is a conflict between pre-commit CI and pre-commit running in Zuul, we discussed it on architecture but there is no action item and I don't remember the outcome. |
|
me neither, @lbarcziova? |
|
@nforro could you do the same as in packit/packit-service@a858f3a here? And for now also disable the required check for pre-commit-ci |
|
Build failed. ❌ pre-commit FAILURE in 1m 11s |
|
@lbarcziova The problem is, (locally run) prettier messes up this part (basically removing most line ends and making it two lines): packit.dev/posts/aws-and-image-builder/index.md Lines 60 to 79 in d708e19
|
|
It works when I reindex the numbered lists. Is that ok? |
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 10s |
lbarcziova
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
I guess not, it breaks the reference to |
|
Making it nested numbered lists so I could write |
Signed-off-by: Nikola Forró <nforro@redhat.com>
|
I don't think there is a way to fix this, so I've excluded the file. WDYT? |
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 18s |
works for me to get this merged, thanks! |
|
Build succeeded (gate pipeline). ✔️ pre-commit SUCCESS in 1m 19s |
cbec9df
into
packit:main
No description provided.