Skip to content

Conversation

@nforro
Copy link
Member

@nforro nforro commented Aug 18, 2025

No description provided.

Signed-off-by: Nikola Forró <nforro@redhat.com>
@softwarefactory-project-zuul
Copy link
Contributor

@nforro
Copy link
Member Author

nforro commented Aug 18, 2025

What to do with the prettier errors?

@majamassarini
Copy link
Member

taking the ci pre commit changes, wouldn't fix it?

@nforro
Copy link
Member Author

nforro commented Aug 18, 2025

taking the ci pre commit changes, wouldn't fix it?

There is a conflict between pre-commit CI and pre-commit running in Zuul, we discussed it on architecture but there is no action item and I don't remember the outcome.

@majamassarini
Copy link
Member

me neither, @lbarcziova?

@lbarcziova
Copy link
Member

lbarcziova commented Aug 18, 2025

@nforro could you do the same as in packit/packit-service@a858f3a here? And for now also disable the required check for pre-commit-ci

@softwarefactory-project-zuul
Copy link
Contributor

@nforro
Copy link
Member Author

nforro commented Aug 18, 2025

@lbarcziova The problem is, (locally run) prettier messes up this part (basically removing most line ends and making it two lines):

- Create a new cloud image through the **Image Builder console**, go to https://console.redhat.com/insights/image-builder
7. Login with your _Red Hat developer_ account.
8. Click on the `Create Image` button, choose _AWS image_ type and follow the wizard.
9. **WAIT for the build to finish**.
10. Open the `Launch` link for the builded image.
- Launch and access the AWS image through the **AWS management console**, go to https://aws.amazon.com/console/
11. The previous link will open an AWS console tab with the
_Launch an Instance_ wizard preset to use the builded image.
You need to login into the _AWS management console_ using an _AWS Account ID_
allowed to access the _AMI Image_ you just created.
12. Select a **Key pair**, or create one if you don't have it already,
to be able to ssh the image later.
13. Click on `Launch Instance`
14. Connect to instance using an ssh client
15. Add the previously created COPR repo to the list of available dnf repositories.
16. Install the package you have created at step number 4.
17. Now you are ready to test your code in a real cloud image.

@nforro
Copy link
Member Author

nforro commented Aug 18, 2025

It works when I reindex the numbered lists. Is that ok?

@softwarefactory-project-zuul
Copy link
Contributor

Copy link
Member

@lbarcziova lbarcziova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nforro
Copy link
Member Author

nforro commented Aug 18, 2025

I guess not, it breaks the reference to steps 4-16 below.

@nforro
Copy link
Member Author

nforro commented Aug 18, 2025

Making it nested numbered lists so I could write steps 1.4-3.6 instead makes prettier go even more crazy 🤷‍♂️

Signed-off-by: Nikola Forró <nforro@redhat.com>
@nforro
Copy link
Member Author

nforro commented Aug 18, 2025

I don't think there is a way to fix this, so I've excluded the file. WDYT?

@softwarefactory-project-zuul
Copy link
Contributor

@lbarcziova
Copy link
Member

I don't think there is a way to fix this, so I've excluded the file. WDYT?

works for me to get this merged, thanks!

@nforro nforro added the mergeit Merge via Zuul label Aug 18, 2025
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://softwarefactory-project.io/zuul/t/packit-service/buildset/9acb2969790d4ef2b951039e159b5707

✔️ pre-commit SUCCESS in 1m 19s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit cbec9df into packit:main Aug 18, 2025
4 checks passed
@nforro nforro deleted the week-33-blog branch August 18, 2025 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mergeit Merge via Zuul

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants