-
Notifications
You must be signed in to change notification settings - Fork 54
Add pictures to documentation #1055
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pictures to documentation #1055
Conversation
|
Build failed. ❌ pre-commit FAILURE in 1m 19s |
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 23s |
majamassarini
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love the process-diagram picture! Super helpful.
And also all the others pictures you have added can be really helpful.
Thanks a lot!
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 18s |
e0e9d7e to
1ef23e2
Compare
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 15s |
1ef23e2 to
f12fecd
Compare
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 18s |
|
Should be fixed now, I hope |
majamassarini
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
lbarcziova
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great!
|
Build succeeded (gate pipeline). ✔️ pre-commit SUCCESS in 1m 13s |
403d340
into
packit:main
I've added a couple of pictures to the documentation (from old presentations, and screenshots of public repos) in places I thought might fit. I would personally remove most of them. Please let me know if there is something that would be better removed or moved elsewhere.
TODO:
Fixes #2638