Skip to content

🌱 Summary template path fix + prometheus skip#2536

Open
dtfranz wants to merge 1 commit intooperator-framework:mainfrom
dtfranz:fix-summary-gen
Open

🌱 Summary template path fix + prometheus skip#2536
dtfranz wants to merge 1 commit intooperator-framework:mainfrom
dtfranz:fix-summary-gen

Conversation

@dtfranz
Copy link
Contributor

@dtfranz dtfranz commented Mar 4, 2026

Fixes the template path for summary generation, the service monitor config for operator-controller, and skips prometheus deployment when summary is not enabled to speed up testing.

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

Copilot AI review requested due to automatic review settings March 4, 2026 02:41
@openshift-ci openshift-ci bot requested review from bentito and camilamacedo86 March 4, 2026 02:42
@netlify
Copy link

netlify bot commented Mar 4, 2026

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit ee2764e
🔍 Latest deploy log https://app.netlify.com/projects/olmv1/deploys/69a7eefa42683500087937e3
😎 Deploy Preview https://deploy-preview-2536--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@openshift-ci
Copy link

openshift-ci bot commented Mar 4, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign camilamacedo86 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the path used to load markdown templates for E2E summary generation and avoids deploying Prometheus in E2E runs when summary output is not requested, reducing local/CI test setup time.

Changes:

  • Correct template glob path for summary generation to point at internal/shared/util/test/templates.
  • Make Prometheus deployment conditional on E2E_SUMMARY_OUTPUT being set (skip when unset).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
internal/shared/util/test/summary.go Updates the template directory used by executeTemplate so summary markdown generation can find the checked-in templates.
Makefile Skips the prometheus deployment step when E2E_SUMMARY_OUTPUT is empty, aligning Prometheus setup with whether summary generation will run.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Mar 4, 2026

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.57%. Comparing base (fb28936) to head (ee2764e).
⚠️ Report is 23 commits behind head on main.

Files with missing lines Patch % Lines
internal/shared/util/test/summary.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2536      +/-   ##
==========================================
- Coverage   73.23%   68.57%   -4.67%     
==========================================
  Files         102      131      +29     
  Lines        8505     9288     +783     
==========================================
+ Hits         6229     6369     +140     
- Misses       1801     2433     +632     
- Partials      475      486      +11     
Flag Coverage Δ
e2e 42.59% <ø> (-3.30%) ⬇️
experimental-e2e 51.83% <ø> (-1.59%) ⬇️
unit 53.71% <0.00%> (-4.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Fixes the template path for summary generation and skips prometheus deployment when summary is not enabled to speed up testing.

Signed-off-by: Daniel Franz <dfranz@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants