Skip to content

Conversation

@mrkisaolamb
Copy link
Contributor

Reverts #1017

@openshift-ci openshift-ci bot requested review from SeanMooney and stuggi October 22, 2025 10:36
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 22, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrkisaolamb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 22, 2025

@mrkisaolamb: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/functional 0842d41 link true /test functional

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@stuggi
Copy link
Contributor

stuggi commented Oct 22, 2025

@mrkisaolamb with this the jobs passed. We'd have to override the functional test as it would require the envtest-setup PR, or we have to merge this into the other PR.

@SeanMooney
Copy link
Contributor

if need gibi or i can override ci and force merge if required to break the depency loop but i have no issue with merging this with the other change.

@gibizer
Copy link
Contributor

gibizer commented Oct 22, 2025

I synced with Kamil we need this to be able to unblock the functional in the other commit. And then we have to re-investigate the original CI issue.

@gibizer
Copy link
Contributor

gibizer commented Oct 22, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Oct 22, 2025
@gibizer gibizer merged commit 33498ee into main Oct 22, 2025
10 of 13 checks passed
@gibizer gibizer deleted the revert-1017-fix-ci branch October 22, 2025 14:20
@gibizer
Copy link
Contributor

gibizer commented Oct 22, 2025

I force merged it as we are in a chicken and egg situation

@stuggi
Copy link
Contributor

stuggi commented Oct 22, 2025

thanks, we may also have to do the same on the 18.0-fr4 branch.

@gibizer
Copy link
Contributor

gibizer commented Oct 22, 2025

/cherry-pick 18.0-fr4

@openshift-cherrypick-robot

@gibizer: new pull request created: #1035

Details

In response to this:

/cherry-pick 18.0-fr4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants