[release-4.16] OCPBUGS-77253: Machine-config controller should not log about non-existent pull-secret changes

[openshift-cherrypick-robot]

This is an automated cherry-pick of #5679

/assign dkhater-redhat

[openshift-ci-robot]

@openshift-cherrypick-robot: Jira Issue OCPBUGS-77186 has been cloned as Jira Issue OCPBUGS-77253. Will retitle bug to link to clone.
/retitle [release-4.16] OCPBUGS-77253: Machine-config controller should not log about non-existent pull-secret changes

Details

In response to this:

This is an automated cherry-pick of #5679

/assign dkhater-redhat

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-77253, which is invalid:

• expected dependent Jira Issue OCPBUGS-77186 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #5679

/assign dkhater-redhat

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[HarshwardhanPatil07]

pre-merge Verification: PASSED

Environment Setup:
Platform: AWS
Fixed Version: 4.16.0-0-2026-02-27-045414-test-ci-ln-qii1zpk-latest

1. Verification on Fix

Observation: The count remained stable at 2 and did not increment over time (pull-secret was not modified).

Verification Steps:

harshpat@harshpat-thinkpadp1gen4i:~/Downloads$ oc get clusterversion
NAME      VERSION                                                AVAILABLE   PROGRESSING   SINCE   STATUS
version   4.16.0-0-2026-02-27-045414-test-ci-ln-qii1zpk-latest   True        False         88m     Cluster version is 4.16.0-0-2026-02-27-045414-test-ci-ln-qii1zpk-latest

harshpat@harshpat-thinkpadp1gen4i:~/Downloads$ oc -n openshift-machine-config-operator logs -l k8s-app=machine-config-controller -c machine-config-controller --tail -1 | grep -c 'Re-syncing ControllerConfig due to secret pull-secret change'
2

After some time

harshpat@harshpat-thinkpadp1gen4i:~/Downloads$ oc -n openshift-machine-config-operator logs -l k8s-app=machine-config-controller -c machine-config-controller --tail -1 | grep -c 'Re-syncing ControllerConfig due to secret pull-secret change'
2

/label qe-approved
/verified by @HarshwardhanPatil07

[openshift-ci-robot]

@HarshwardhanPatil07: This PR has been marked as verified by @HarshwardhanPatil07.

Details

In response to this:

pre-merge Verification: PASSED

Environment Setup:
Platform: AWS
Fixed Version: 4.16.0-0-2026-02-27-045414-test-ci-ln-qii1zpk-latest

1. Verification on Fix

Observation: The count remained stable at 2 and did not increment over time (pull-secret was not modified).

Verification Steps:

harshpat@harshpat-thinkpadp1gen4i:~/Downloads$ oc get clusterversion
NAME      VERSION                                                AVAILABLE   PROGRESSING   SINCE   STATUS
version   4.16.0-0-2026-02-27-045414-test-ci-ln-qii1zpk-latest   True        False         88m     Cluster version is 4.16.0-0-2026-02-27-045414-test-ci-ln-qii1zpk-latest

harshpat@harshpat-thinkpadp1gen4i:~/Downloads$ oc -n openshift-machine-config-operator logs -l k8s-app=machine-config-controller -c machine-config-controller --tail -1 | grep -c 'Re-syncing ControllerConfig due to secret pull-secret change'
2

After some time

harshpat@harshpat-thinkpadp1gen4i:~/Downloads$ oc -n openshift-machine-config-operator logs -l k8s-app=machine-config-controller -c machine-config-controller --tail -1 | grep -c 'Re-syncing ControllerConfig due to secret pull-secret change'
2

/label qe-approved
/verified by @HarshwardhanPatil07

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-77253, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.16.z) matches configured target version for branch (4.16.z)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
• release note type set to "Release Note Not Required"
• dependent bug Jira Issue OCPBUGS-77186 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
• dependent Jira Issue OCPBUGS-77186 targets the "4.17.z" version, which is one of the valid target versions: 4.17.0, 4.17.z
• bug has dependents

Requesting review from QA contact:
/cc @sergiordlr

Details

In response to this:

This is an automated cherry-pick of #5679

/assign dkhater-redhat

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[dkhater-redhat]

/retest-required

[dkhater-redhat]

/jira refresh

[openshift-ci-robot]

@dkhater-redhat: This pull request references Jira Issue OCPBUGS-77253, which is invalid:

• expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Verified instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[dkhater-redhat]

/retest-required

[dkhater-redhat]

/retest-required

[dkhater-redhat]

/override ci/prow/e2e-gcp-op
/override ci/prow/e2e-gcp-op-single-node

[openshift-ci]

@dkhater-redhat: Overrode contexts on behalf of dkhater-redhat: ci/prow/e2e-gcp-op, ci/prow/e2e-gcp-op-single-node

Details

In response to this:

/override ci/prow/e2e-gcp-op
/override ci/prow/e2e-gcp-op-single-node

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[dkhater-redhat]

/jira refresh

[openshift-ci-robot]

@dkhater-redhat: This pull request references Jira Issue OCPBUGS-77253, which is valid.

7 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.16.z) matches configured target version for branch (4.16.z)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
• release note type set to "Release Note Not Required"
• dependent bug Jira Issue OCPBUGS-77186 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
• dependent Jira Issue OCPBUGS-77186 targets the "4.17.z" version, which is one of the valid target versions: 4.17.0, 4.17.z
• bug has dependents

Requesting review from QA contact:
/cc @HarshwardhanPatil07

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[dkhater-redhat]

/approved
/label backport-risk-assessed

[dkhater-redhat]

/approved

[dkhater-redhat]

/approve

[pablintino]

/lgtm
/retest-required

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dkhater-redhat, openshift-cherrypick-robot, pablintino

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [dkhater-redhat]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[dkhater-redhat]

/override ci/prow/e2e-gcp-op
/override ci/prow/e2e-gcp-op-single-node

[openshift-ci]

@dkhater-redhat: Overrode contexts on behalf of dkhater-redhat: ci/prow/e2e-gcp-op, ci/prow/e2e-gcp-op-single-node

Details

In response to this:

/override ci/prow/e2e-gcp-op
/override ci/prow/e2e-gcp-op-single-node

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[dkhater-redhat]

/override ci/prow/e2e-gcp-op
/override ci/prow/e2e-gcp-op-single-node

[openshift-ci]

@dkhater-redhat: Overrode contexts on behalf of dkhater-redhat: ci/prow/e2e-gcp-op, ci/prow/e2e-gcp-op-single-node

Details

In response to this:

/override ci/prow/e2e-gcp-op
/override ci/prow/e2e-gcp-op-single-node

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[dkhater-redhat]

/test e2e-hypershift

[dkhater-redhat]

/override ci/prow/e2e-hypershift

[openshift-ci]

@dkhater-redhat: Overrode contexts on behalf of dkhater-redhat: ci/prow/e2e-hypershift

Details

In response to this:

/override ci/prow/e2e-hypershift

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci-robot]

@openshift-cherrypick-robot: Jira Issue Verification Checks: Jira Issue OCPBUGS-77253
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-77253 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

This is an automated cherry-pick of #5679

/assign dkhater-redhat

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-ovn	277326a	link	unknown	/test e2e-aws-ovn
ci/prow/e2e-gcp-op	277326a	link	unknown	/test e2e-gcp-op
ci/prow/verify	277326a	link	unknown	/test verify
ci/prow/e2e-gcp-op-single-node	277326a	link	unknown	/test e2e-gcp-op-single-node
ci/prow/unit	277326a	link	unknown	/test unit
ci/prow/e2e-hypershift	277326a	link	unknown	/test e2e-hypershift
ci/prow/e2e-aws-ovn-upgrade	277326a	link	unknown	/test e2e-aws-ovn-upgrade
ci/prow/images	277326a	link	unknown	/test images

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.