Skip to content

[release-4.17] OCPBUGS-77186: Machine-config controller should not log about non-existent pull-secret changes#5679

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:release-4.17from
dkhater-redhat:fix-pull-secret-log-spam-4.17
Feb 24, 2026
Merged

[release-4.17] OCPBUGS-77186: Machine-config controller should not log about non-existent pull-secret changes#5679
openshift-merge-bot[bot] merged 1 commit intoopenshift:release-4.17from
dkhater-redhat:fix-pull-secret-log-spam-4.17

Conversation

@dkhater-redhat
Copy link
Contributor

make verify error

- What I did

- How to verify it

- Description for the changelog

make verify error
@openshift-ci-robot openshift-ci-robot added jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 19, 2026
@openshift-ci-robot
Copy link
Contributor

@dkhater-redhat: This pull request references Jira Issue OCPBUGS-77071, which is invalid:

  • expected the bug to target either version "4.17." or "openshift-4.17.", but it targets "4.19.z" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is MODIFIED instead
  • expected dependent Jira Issue OCPBUGS-77008 to target a version in 4.18.0, 4.18.z, but it targets "4.20.z" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

make verify error

- What I did

- How to verify it

- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from djoshy and yuqi-zhang February 19, 2026 21:07
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 19, 2026
@dkhater-redhat dkhater-redhat changed the title [release-4.17] OCPBUGS-77071: Machine-config controller should not log about non-existent pull-secret changes [release-4.17] Machine-config controller should not log about non-existent pull-secret changes Feb 19, 2026
@openshift-ci-robot openshift-ci-robot removed jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 19, 2026
@openshift-ci-robot
Copy link
Contributor

@dkhater-redhat: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

Details

In response to this:

make verify error

- What I did

- How to verify it

- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.19.0-0.nightly-2026-02-20-061735

@dkhater-redhat
Copy link
Contributor Author

/test e2e-gcp-op-single-node

@dkhater-redhat
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@dkhater-redhat: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@dkhater-redhat dkhater-redhat changed the title [release-4.17] Machine-config controller should not log about non-existent pull-secret changes [release-4.17] OCPBUGS-77186: Machine-config controller should not log about non-existent pull-secret changes Feb 24, 2026
@openshift-ci-robot openshift-ci-robot added jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Feb 24, 2026
@openshift-ci-robot
Copy link
Contributor

@dkhater-redhat: This pull request references Jira Issue OCPBUGS-77186, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.17.z) matches configured target version for branch (4.17.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-77092 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-77092 targets the "4.18.z" version, which is one of the valid target versions: 4.18.0, 4.18.z
  • bug has dependents

Requesting review from QA contact:
/cc @HarshwardhanPatil07

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

make verify error

- What I did

- How to verify it

- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@dkhater-redhat
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@dkhater-redhat: This pull request references Jira Issue OCPBUGS-77186, which is valid.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.17.z) matches configured target version for branch (4.17.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-77092 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-77092 targets the "4.18.z" version, which is one of the valid target versions: 4.18.0, 4.18.z
  • bug has dependents

Requesting review from QA contact:
/cc @HarshwardhanPatil07

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@dkhater-redhat
Copy link
Contributor Author

/backport-risk-assessed
/approve

@HarshwardhanPatil07
Copy link

pre-merge Verification: PASSED

Environment Setup:
Platform: AWS
Fixed Version: 4.17.0-0-2026-02-24-025435-test-ci-ln-xcljk2b-latest

1. Verification on Fix

Observation: The count remained stable at 2 and did not increment over time (pull-secret was not modified).

Verification Steps:

harshpat@harshpat-thinkpadp1gen4i:~/Downloads$ oc get clusterversion
NAME      VERSION                                                AVAILABLE   PROGRESSING   SINCE   STATUS
version   4.17.0-0-2026-02-24-025435-test-ci-ln-xcljk2b-latest   True        False         62m     Cluster version is 4.17.0-0-2026-02-24-025435-test-ci-ln-xcljk2b-latest

harshpat@harshpat-thinkpadp1gen4i:~/Downloads$ oc -n openshift-machine-config-operator logs -l k8s-app=machine-config-controller -c machine-config-controller --tail -1 | grep -c 'Re-syncing ControllerConfig due to secret pull-secret change'
2

After some time

harshpat@harshpat-thinkpadp1gen4i:~/Downloads$ oc -n openshift-machine-config-operator logs -l k8s-app=machine-config-controller -c machine-config-controller --tail -1 | grep -c 'Re-syncing ControllerConfig due to secret pull-secret change'
2

/label qe-approved
/verified by @HarshwardhanPatil07

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Feb 24, 2026
@openshift-ci-robot
Copy link
Contributor

@HarshwardhanPatil07: This PR has been marked as verified by @HarshwardhanPatil07.

Details

In response to this:

pre-merge Verification: PASSED

Environment Setup:
Platform: AWS
Fixed Version: 4.17.0-0-2026-02-24-025435-test-ci-ln-xcljk2b-latest

1. Verification on Fix

Observation: The count remained stable at 2 and did not increment over time (pull-secret was not modified).

Verification Steps:

harshpat@harshpat-thinkpadp1gen4i:~/Downloads$ oc get clusterversion
NAME      VERSION                                                AVAILABLE   PROGRESSING   SINCE   STATUS
version   4.17.0-0-2026-02-24-025435-test-ci-ln-xcljk2b-latest   True        False         62m     Cluster version is 4.17.0-0-2026-02-24-025435-test-ci-ln-xcljk2b-latest

harshpat@harshpat-thinkpadp1gen4i:~/Downloads$ oc -n openshift-machine-config-operator logs -l k8s-app=machine-config-controller -c machine-config-controller --tail -1 | grep -c 'Re-syncing ControllerConfig due to secret pull-secret change'
2

After some time

harshpat@harshpat-thinkpadp1gen4i:~/Downloads$ oc -n openshift-machine-config-operator logs -l k8s-app=machine-config-controller -c machine-config-controller --tail -1 | grep -c 'Re-syncing ControllerConfig due to secret pull-secret change'
2

/label qe-approved
/verified by @HarshwardhanPatil07

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Feb 24, 2026
Copy link
Member

@isabella-janssen isabella-janssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/label backport-risk-assessed

Looks like a clean backport.

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Feb 24, 2026
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 24, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 24, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dkhater-redhat, HarshwardhanPatil07, isabella-janssen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dkhater-redhat
Copy link
Contributor Author

/test e2e-gcp-op

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 24, 2026

@dkhater-redhat: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit dd398f8 into openshift:release-4.17 Feb 24, 2026
11 checks passed
@openshift-ci-robot
Copy link
Contributor

@dkhater-redhat: Jira Issue Verification Checks: Jira Issue OCPBUGS-77186
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-77186 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

make verify error

- What I did

- How to verify it

- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@dkhater-redhat
Copy link
Contributor Author

/cherry-pick release-4.16

@openshift-cherrypick-robot

@dkhater-redhat: new pull request created: #5694

Details

In response to this:

/cherry-pick release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.17.0-0.nightly-2026-02-25-170125

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.