Skip to content

Fix Jackson 2.21+ conflicting creators in AWT recipes #1007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timtebeek merged 1 commit into from
Mar 10, 2026
+30 −15
Merged

Fix Jackson 2.21+ conflicting creators in AWT recipes #1007

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions src/main/java/org/openrewrite/java/migrate/ReplaceAWTGetPeerMethod.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
package org.openrewrite.java.migrate;

import com.fasterxml.jackson.annotation.JsonCreator;
import lombok.AllArgsConstructor;
import lombok.EqualsAndHashCode;
import lombok.Value;
import org.jspecify.annotations.Nullable;
Expand All @@ -29,7 +28,6 @@
import org.openrewrite.java.tree.TypeUtils;
import org.openrewrite.java.tree.TypedTree;

@AllArgsConstructor
@EqualsAndHashCode(callSuper = false)
@Value
public class ReplaceAWTGetPeerMethod extends Recipe {
Expand All @@ -47,9 +45,13 @@ public class ReplaceAWTGetPeerMethod extends Recipe {
String lightweightPeerFQCN;

@JsonCreator
public ReplaceAWTGetPeerMethod() {
getPeerMethodPattern = "java.awt.* getPeer()";
lightweightPeerFQCN = "java.awt.peer.LightweightPeer";
public ReplaceAWTGetPeerMethod(
@Nullable String getPeerMethodPattern,
@Nullable String lightweightPeerFQCN) {
this.getPeerMethodPattern = getPeerMethodPattern == null ?
"java.awt.* getPeer()" : getPeerMethodPattern;
this.lightweightPeerFQCN = lightweightPeerFQCN == null ?
"java.awt.peer.LightweightPeer" : lightweightPeerFQCN;
}

String displayName = "Replace AWT `getPeer()` method";
Expand Down
33 changes: 23 additions & 10 deletions src/main/java/org/openrewrite/java/migrate/ReplaceComSunAWTUtilitiesMethods.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,9 @@
package org.openrewrite.java.migrate;

import com.fasterxml.jackson.annotation.JsonCreator;
import lombok.AllArgsConstructor;
import lombok.EqualsAndHashCode;
import lombok.Value;
import org.jspecify.annotations.Nullable;
import org.openrewrite.ExecutionContext;
import org.openrewrite.Option;
import org.openrewrite.Recipe;
Expand All @@ -28,7 +28,6 @@
import org.openrewrite.java.MethodMatcher;
import org.openrewrite.java.tree.J;

@AllArgsConstructor
@EqualsAndHashCode(callSuper = false)
@Value
public class ReplaceComSunAWTUtilitiesMethods extends Recipe {
Expand Down Expand Up @@ -77,14 +76,28 @@ public class ReplaceComSunAWTUtilitiesMethods extends Recipe {
String setComponentMixingCutoutShapePattern;

@JsonCreator
public ReplaceComSunAWTUtilitiesMethods() {
getAWTIsWindowsTranslucencyPattern = "com.sun.awt.AWTUtilities isTranslucencySupported(com.sun.awt.AWTUtilities.Translucency)";
getWindowOpacityPattern = "com.sun.awt.AWTUtilities getWindowOpacity(java.awt.Window)";
getWindowShapePattern = "com.sun.awt.AWTUtilities getWindowShape(java.awt.Window)";
isWindowOpaquePattern = "com.sun.awt.AWTUtilities isWindowOpaque(java.awt.Window)";
isTranslucencyCapablePattern = "com.sun.awt.AWTUtilities isTranslucencyCapable(java.awt.GraphicsConfiguration)";
setComponentMixingCutoutShapePattern = "com.sun.awt.AWTUtilities setComponentMixingCutoutShape(java.awt.Component,java.awt.Shape)";
setWindowOpacityPattern = "com.sun.awt.AWTUtilities setWindowOpacity(java.awt.Window, float)";
public ReplaceComSunAWTUtilitiesMethods(
@Nullable String getAWTIsWindowsTranslucencyPattern,
@Nullable String isWindowOpaquePattern,
@Nullable String isTranslucencyCapablePattern,
@Nullable String setWindowOpacityPattern,
@Nullable String getWindowOpacityPattern,
@Nullable String getWindowShapePattern,
@Nullable String setComponentMixingCutoutShapePattern) {
this.getAWTIsWindowsTranslucencyPattern = getAWTIsWindowsTranslucencyPattern == null ?
"com.sun.awt.AWTUtilities isTranslucencySupported(com.sun.awt.AWTUtilities.Translucency)" : getAWTIsWindowsTranslucencyPattern;
this.isWindowOpaquePattern = isWindowOpaquePattern == null ?
"com.sun.awt.AWTUtilities isWindowOpaque(java.awt.Window)" : isWindowOpaquePattern;
this.isTranslucencyCapablePattern = isTranslucencyCapablePattern == null ?
"com.sun.awt.AWTUtilities isTranslucencyCapable(java.awt.GraphicsConfiguration)" : isTranslucencyCapablePattern;
this.setWindowOpacityPattern = setWindowOpacityPattern == null ?
"com.sun.awt.AWTUtilities setWindowOpacity(java.awt.Window, float)" : setWindowOpacityPattern;
this.getWindowOpacityPattern = getWindowOpacityPattern == null ?
"com.sun.awt.AWTUtilities getWindowOpacity(java.awt.Window)" : getWindowOpacityPattern;
this.getWindowShapePattern = getWindowShapePattern == null ?
"com.sun.awt.AWTUtilities getWindowShape(java.awt.Window)" : getWindowShapePattern;
this.setComponentMixingCutoutShapePattern = setComponentMixingCutoutShapePattern == null ?
"com.sun.awt.AWTUtilities setComponentMixingCutoutShape(java.awt.Component,java.awt.Shape)" : setComponentMixingCutoutShapePattern;
}

String displayName = "Replace `com.sun.awt.AWTUtilities` static method invocations";
Expand Down
Loading