Fix Jackson 2.21+ conflicting creators in AWT recipes#1007
Merged
Conversation
Remove `@AllArgsConstructor` from `ReplaceAWTGetPeerMethod` and `ReplaceComSunAWTUtilitiesMethods` and replace the no-arg `@JsonCreator` constructor with an all-args `@JsonCreator` constructor accepting `@Nullable` parameters with defaults. This eliminates the conflicting property-based creators caused by Lombok's `@ConstructorProperties` annotation on the generated all-args constructor. Closes #1003
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove
@AllArgsConstructorfromReplaceAWTGetPeerMethodandReplaceComSunAWTUtilitiesMethodsReplace the no-arg
@JsonCreatorconstructor with an all-args@JsonCreatorconstructor accepting@Nullableparameters with defaultsThis eliminates the
InvalidDefinitionExceptioncaused by Lombok's@ConstructorPropertieson the generated all-args constructor conflicting with the explicit@JsonCreatorno-arg constructor (exposed by jackson-databind#5045 in Jackson 2.21+)Follows the same pattern already used by
ReplaceLocalizedStreamMethodsCloses Jackson 2.21+ compatibility: InvalidDefinitionException due to conflicting creators in ReplaceAWTGetPeerMethod and ReplaceComSunAWTUtilitiesMethods #1003
Test plan
ReplaceAWTGetPeerMethodTestpassReplaceComSunAWTUtilitiesMethodsTestpass