Skip to content

Bugfix - ofxToggle/ofxButton size changes properly update checkbox size #8503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ofTheo merged 4 commits into from
Feb 6, 2026
+15 −1
Merged

Bugfix - ofxToggle/ofxButton size changes properly update checkbox size #8503

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
437f10d
ofxToggle setSize override to correctly change checkbox size
fearn-e Feb 5, 2026
06e312e
ofxButton setSize override to correctly change checkbox size
fearn-e Feb 5, 2026
491d05e
mistyped ofxToggle -> ofxButton
fearn-e Feb 6, 2026
119ad22
Merge branch 'openframeworks:master' into bugfix-update-ui-sizes
fearn-e Feb 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions addons/ofxGui/src/ofxButton.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,13 @@ ofxButton* ofxButton::setup(const std::string& toggleName, float width, float he
return this;
}

void ofxButton::setSize(float width, float height){
b.width = width;
b.height = height;
checkboxRect.set(1, 1, b.height - 2, b.height - 2);
sizeChangedCB();
}

void ofxButton::generateDraw(){
bg.clear();
bg.setFillColor(thisBackgroundColor);
Expand Down
1 change: 1 addition & 0 deletions addons/ofxGui/src/ofxButton.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ class ofxButton : public ofxToggle{
~ofxButton();
ofxButton* setup(ofParameter<void> _bVal, float width = defaultWidth, float height = defaultHeight);
ofxButton* setup(const std::string& toggleName, float width = defaultWidth, float height = defaultHeight);
virtual void setSize(float width, float height);
void generateDraw();

virtual bool mouseReleased(ofMouseEventArgs & args);
Expand Down
6 changes: 6 additions & 0 deletions addons/ofxGui/src/ofxToggle.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,12 @@ ofxToggle * ofxToggle::setup(const std::string& toggleName, bool _bVal, float wi
return setup(value,width,height);
}

void ofxToggle::setSize(float width, float height){
b.width = width;
b.height = height;
checkboxRect.set(1, 1, b.height - 2, b.height - 2);
sizeChangedCB();
}

bool ofxToggle::mouseMoved(ofMouseEventArgs & args){
if(isGuiDrawing() && b.inside(args)){
Expand Down
2 changes: 1 addition & 1 deletion addons/ofxGui/src/ofxToggle.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ class ofxToggle : public ofxBaseGui{
ofxToggle(ofParameter<bool> _bVal, float width = defaultWidth, float height = defaultHeight);
ofxToggle * setup(ofParameter<bool> _bVal, float width = defaultWidth, float height = defaultHeight);
ofxToggle * setup(const std::string& toggleName, bool _bVal, float width = defaultWidth, float height = defaultHeight);

virtual void setSize(float width, float height);

virtual bool mouseMoved(ofMouseEventArgs & args);
virtual bool mousePressed(ofMouseEventArgs & args);
Expand Down
Loading