Bugfix - ofxToggle/ofxButton size changes properly update checkbox size#8503
Merged
ofTheo merged 4 commits intoopenframeworks:masterfrom Feb 6, 2026
Merged
Bugfix - ofxToggle/ofxButton size changes properly update checkbox size#8503ofTheo merged 4 commits intoopenframeworks:masterfrom
ofTheo merged 4 commits intoopenframeworks:masterfrom
Conversation
Member
|
curious why this was closed - thanks @fearn-e |
Contributor
Author
|
@ofTheo noticed the github actions were flagging errors with some of the builds, didn't want to waste the maintainers' time so thought I'd close it while I double checked what went wrong. Full disclosure -- was hoping no one would notice! |
Member
|
No problem!! |
Contributor
Author
Ah, thank you, serves me right for opening a PR at the end of the day, I'll fix and reopen it in the morning 😄 |
Contributor
Author
|
Should be all good now! |
Member
|
Thanks @fearn-e ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When ofxToggle/ofxButton were resized, it never changed the checkboxRect value. It was only originally set in the Setup function, leading to having to retrigger Setup for any buttons and toggles.
Fix is to create overrides for the setSize function from ofxBaseGui, for ofxToggle and ofxButton.
Tested only on Windows, compiles and works fine, though I doubt it should have any issues on other OSs.
First PR for OF, so hopefully I did everything right. 🙂