Skip to content

Fix OTLP marshaling for empty string attributes#8014

Open
trask wants to merge 5 commits intoopen-telemetry:mainfrom
trask:empty-string-attributes
Open

Fix OTLP marshaling for empty string attributes#8014
trask wants to merge 5 commits intoopen-telemetry:mainfrom
trask:empty-string-attributes

Conversation

@trask
Copy link
Member

@trask trask commented Jan 26, 2026

Based on https://protobuf.dev/programming-guides/proto3/#oneof

If you set a oneof field to the default value (such as setting an int32 oneof field to 0), the “case” of that oneof field will be set, and the value will be serialized on the wire.

@codecov
Copy link

codecov bot commented Jan 26, 2026

Codecov Report

❌ Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 90.24%. Comparing base (6893380) to head (614e662).

Files with missing lines Patch % Lines
...orter/internal/marshal/StatelessMarshalerUtil.java 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #8014      +/-   ##
============================================
+ Coverage     90.23%   90.24%   +0.01%     
- Complexity     7602     7604       +2     
============================================
  Files           838      838              
  Lines         22806    22807       +1     
  Branches       2274     2272       -2     
============================================
+ Hits          20578    20583       +5     
+ Misses         1518     1516       -2     
+ Partials        710      708       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@trask trask marked this pull request as ready for review January 26, 2026 22:35
@trask trask requested a review from a team as a code owner January 26, 2026 22:35
@trask trask force-pushed the empty-string-attributes branch from b81a3d2 to b03900f Compare February 7, 2026 02:44
@trask trask force-pushed the empty-string-attributes branch from b03900f to 614e662 Compare February 7, 2026 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants