Skip to content

Conversation

@72umesh
Copy link
Contributor

@72umesh 72umesh commented Jan 3, 2026

Description

This PR fixes an accessibility issue in the Sidebar navigation.
Currently, sidebar items are placed directly inside <ul> without <li> wrappers, which breaks HTML list rules and causes accessibility errors.

Validation

Before the fix (invalid – direct <a> inside <ul>):

530712270-c5d9d7f8-f13a-4cfc-9225-26bd71b74e3e

After the fix (correct – wrapped in <li>):

Sidebar Accessibilty Issue

Related Issues

#8465

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run pnpm format to ensure the code follows the style guide.
  • I have run pnpm test to check if all tests are passing.
  • I have run pnpm build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

@72umesh 72umesh requested a review from a team as a code owner January 3, 2026 09:21
@vercel
Copy link

vercel bot commented Jan 3, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
nodejs-org Ready Ready Preview Jan 4, 2026 3:25am

@github-actions
Copy link
Contributor

github-actions bot commented Jan 3, 2026

👋 Codeowner Review Request

The following codeowners have been identified for the changed files:

Team reviewers: @nodejs/nodejs-website

Please review the changes when you have a chance. Thank you! 🙏

Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@github-actions
Copy link
Contributor

github-actions bot commented Jan 3, 2026

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 98 🟢 96 🟢 100 🟢 100 🔗
/en/about 🟢 99 🟢 97 🟢 100 🟠 88 🔗
/en/about/previous-releases 🟢 98 🟢 100 🟢 100 🟢 100 🔗
/en/download 🟢 97 🟢 100 🟢 100 🟢 100 🔗
/en/download/archive/current 🟢 100 🟢 100 🟢 100 🟢 100 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🟢 100 🔗

@avivkeller avivkeller enabled auto-merge January 5, 2026 17:18
@codecov
Copy link

codecov bot commented Jan 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.24%. Comparing base (fcfc7e2) to head (0aceb3b).
⚠️ Report is 4 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8515      +/-   ##
==========================================
+ Coverage   74.21%   74.24%   +0.03%     
==========================================
  Files         106      106              
  Lines        9102     9102              
  Branches      308      307       -1     
==========================================
+ Hits         6755     6758       +3     
+ Misses       2345     2342       -3     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@avivkeller avivkeller added this pull request to the merge queue Jan 5, 2026
Merged via the queue into nodejs:main with commit 8c5a7dd Jan 5, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants