-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
fix(a11y): wrap SidebarItem with <li> in SidebarGroup #8515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(a11y): wrap SidebarItem with <li> in SidebarGroup #8515
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
👋 Codeowner Review RequestThe following codeowners have been identified for the changed files: Team reviewers: @nodejs/nodejs-website Please review the changes when you have a chance. Thank you! 🙏 |
ovflowd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM
|
Lighthouse Results
|
packages/ui-components/src/Containers/Sidebar/SidebarGroup/index.tsx
Outdated
Show resolved
Hide resolved
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8515 +/- ##
==========================================
+ Coverage 74.21% 74.24% +0.03%
==========================================
Files 106 106
Lines 9102 9102
Branches 308 307 -1
==========================================
+ Hits 6755 6758 +3
+ Misses 2345 2342 -3
Partials 2 2 ☔ View full report in Codecov by Sentry. |
Description
This PR fixes an accessibility issue in the
Sidebarnavigation.Currently, sidebar items are placed directly inside
<ul>without<li>wrappers, which breaks HTML list rules and causes accessibility errors.Validation
Before the fix (invalid – direct
<a>inside<ul>):After the fix (correct – wrapped in
<li>):Related Issues
#8465
Check List
pnpm formatto ensure the code follows the style guide.pnpm testto check if all tests are passing.pnpm buildto check if the website builds without errors.