Skip to content

Commit 8c5a7dd

Browse files
authored
fix(a11y): wrap SidebarItem with <li> in SidebarGroup (#8515)
* fix(a11y): wrap SidebarItem with <li> in SidebarGroup * refactor(a11y): move <li> wrapper from SidebarGroup to SidebarItem
1 parent db3bed3 commit 8c5a7dd

File tree

1 file changed

+13
-11
lines changed
  • packages/ui-components/src/Containers/Sidebar/SidebarItem

1 file changed

+13
-11
lines changed

packages/ui-components/src/Containers/Sidebar/SidebarItem/index.tsx

Lines changed: 13 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -15,18 +15,20 @@ type SidebarItemProps = {
1515
};
1616

1717
const SidebarItem: FC<SidebarItemProps> = ({ label, link, ...props }) => (
18-
<BaseActiveLink
19-
className={styles.item}
20-
href={link}
21-
activeClassName={styles.active}
22-
{...props}
23-
>
24-
<div className={styles.label}>
25-
<span>{label}</span>
18+
<li>
19+
<BaseActiveLink
20+
className={styles.item}
21+
href={link}
22+
activeClassName={styles.active}
23+
{...props}
24+
>
25+
<div className={styles.label}>
26+
<span>{label}</span>
2627

27-
{/^https?:/.test(link) && <ArrowUpRightIcon className={styles.icon} />}
28-
</div>
29-
</BaseActiveLink>
28+
{/^https?:/.test(link) && <ArrowUpRightIcon className={styles.icon} />}
29+
</div>
30+
</BaseActiveLink>
31+
</li>
3032
);
3133

3234
export default SidebarItem;

0 commit comments

Comments
 (0)