fix(ci): run Tests on Crowdin PRs

[avivkeller]

I’d really appreciate it if someone could take a second look to ensure everything is set up correctly.

---

To prevent recursive triggers, events triggered by the repository’s GITHUB_TOKEN (such as the creation of Crowdin PRs) do not trigger workflows. This wasn’t a problem before, as these workflows were manually triggered for security reasons.

After switching to Codecov, these tests were automated because they are safe to run. However, automatic deployment does not occur on Crowdin PRs. Therefore, this PR introduces the option for manual deployment on Crowdin PRs via the label.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
nodejs-org	✅ Ready (Inspect)	Visit Preview	Apr 19, 2025 6:07pm

[Copilot]

Pull Request Overview

This PR updates the CI workflow to ensure that tests on Crowdin pull requests can be manually deployed via a label while avoiding recursive triggers from the repository’s GITHUB_TOKEN.

• Added support for the pull_request_target event in the workflow triggers.
• Updated conditional execution for quality checks and tests jobs based on the PR type and branch.
• Adjusted the Git Checkout step to correctly reference the commit in pull_request_target events.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.60%. Comparing base (c32c588) to head (f733f69).

✅ All tests successful. No failed tests found.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7668      +/-   ##
==========================================
- Coverage   74.61%   74.60%   -0.02%     
==========================================
  Files          96       96              
  Lines        7689     7689              
  Branches      192      192              
==========================================
- Hits         5737     5736       -1     
- Misses       1950     1951       +1     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[github-actions]

Lighthouse Results

URL	Performance	Accessibility	Best Practices	SEO	Report
/en	🟢 99	🟢 100	🟢 100	🟢 91	🔗
/en/about	🟢 100	🟢 100	🟢 100	🟢 91	🔗
/en/about/previous-releases	🟢 99	🟢 100	🟢 100	🟢 92	🔗
/en/download	🟢 98	🟢 100	🟢 100	🟢 91	🔗
/en/blog	🟢 100	🟢 100	🟢 96	🟢 92	🔗

[bjohansebas]

LGTM

[avivkeller]

Bump @nodejs/web-infra to approve. No rush, obviously, this is just blocking Crowdin PRs from landing.

[ovflowd]

FYI it was intentional back then to not run the tests on Crowdin PRs.

[avivkeller]

That can still be arranged, would you prefer that?

[avivkeller]

Personally, I prefer the alternative solution, as it's less "hacky" and more future-proof: Open Crowdin PRs from @nodejs-github-bot rather than GITHUB_TOKEN. (This is what is done in other repositories in the organization,but we'd have to request a token).

[avivkeller]

Actually, @nodejs-github-bot is a previous contributor, do we already have a token?

[avivkeller]

I'm actually going to continue with that, I like it much better.

[ovflowd]

Personally, I prefer the alternative solution, as it's less "hacky" and more future-proof: Open Crowdin PRs from @nodejs-github-bot rather than GITHUB_TOKEN. (This is what is done in other repositories in the organization,but we'd have to request a token).

That one is reserved by the Build Team -- but we have one specific bot for Crowdin :) whose we have access (web infra team)