Skip to content

Conversation

@avivkeller
Copy link
Member

@avivkeller avivkeller commented Apr 22, 2025

Signed-off-by: Aviv Keller <me@aviv.sh>
@vercel
Copy link

vercel bot commented Apr 22, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Apr 22, 2025 2:56pm

@codecov-commenter
Copy link

codecov-commenter commented Apr 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.61%. Comparing base (c6b6928) to head (644c28a).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7671   +/-   ##
=======================================
  Coverage   74.61%   74.61%           
=======================================
  Files          96       96           
  Lines        7689     7689           
  Branches      192      192           
=======================================
  Hits         5737     5737           
  Misses       1950     1950           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@avivkeller

This comment has been minimized.

@avivkeller
Copy link
Member Author

@ovflowd can you please update this PR with the crowdin bot secret, I'm not sure what the secret is labeled

@ovflowd
Copy link
Member

ovflowd commented Apr 22, 2025

@ovflowd can you please update this PR with the crowdin bot secret, I'm not sure what the secret is labeled

What sort of permissions you need for the Access Token?

@avivkeller
Copy link
Member Author

contents and pull_request write

@ovflowd
Copy link
Member

ovflowd commented Apr 22, 2025

contents and pull_request write

I mean, GitHub Developer Access Token permissions; What scopes?

@avivkeller
Copy link
Member Author

avivkeller commented Apr 22, 2025

I mean, GitHub Developer Access Token permissions; What scopes?

Assuming the token is fine-grained,
"Pull requests" repository permissions (write)
"Contents" repository permissions (write)

Assuming the token is classic,
repo (public_repo should also work)

@ovflowd
Copy link
Member

ovflowd commented Apr 22, 2025

Token created. It expires in 2026 (April 30) -- Name: CROWDIN_GITHUB_BOT_TOKEN

cc @mcollina apparently the Node.js Enterprise sets a limit of how long tokens can last. Can we change that from a maximum of 366 days to no expiration?

Signed-off-by: Aviv Keller <me@aviv.sh>
Signed-off-by: Aviv Keller <me@aviv.sh>
@avivkeller avivkeller marked this pull request as ready for review April 22, 2025 14:56
@avivkeller avivkeller requested a review from a team as a code owner April 22, 2025 14:56
@avivkeller
Copy link
Member Author

avivkeller commented Apr 22, 2025

It worked!

https://github.com/nodejs/nodejs.org/actions/runs/14597939715/

@github-actions
Copy link
Contributor

github-actions bot commented Apr 22, 2025

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 99 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/about/previous-releases 🟢 99 🟢 100 🟢 100 🟢 92 🔗
/en/download 🟢 98 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🟢 92 🔗

@avivkeller
Copy link
Member Author

FYI I've closed the currently open Crowdin PRs, and will make a new one once this lands.

@avivkeller avivkeller added the fast-track Fast Tracking PRs label Apr 22, 2025
@avivkeller
Copy link
Member Author

Fast tracking, as this doesn't change the execution of anything, only the permissions granted.

@avivkeller avivkeller added the github_actions:pull-request Trigger Pull Request Checks label Apr 22, 2025
@avivkeller avivkeller enabled auto-merge April 22, 2025 15:37
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Apr 22, 2025
@avivkeller avivkeller added this pull request to the merge queue Apr 22, 2025
Merged via the queue into main with commit 139b316 Apr 22, 2025
29 checks passed
@avivkeller avivkeller deleted the use-github-bot branch April 22, 2025 15:45
@ovflowd
Copy link
Member

ovflowd commented Apr 22, 2025

Fast tracking, as this doesn't change the execution of anything, only the permissions granted.

The author of the PR cannot request for fast-tracking and approve the fast-tracking. So if you say requesting fast tracking, someone needs to give a 👍 first 🙈

@avivkeller
Copy link
Member Author

😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fast-track Fast Tracking PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants