-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
fix(ci): use Github Bot for Crowdin #7671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Aviv Keller <me@aviv.sh>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #7671 +/- ##
=======================================
Coverage 74.61% 74.61%
=======================================
Files 96 96
Lines 7689 7689
Branches 192 192
=======================================
Hits 5737 5737
Misses 1950 1950
Partials 2 2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This comment has been minimized.
This comment has been minimized.
|
@ovflowd can you please update this PR with the crowdin bot secret, I'm not sure what the secret is labeled |
What sort of permissions you need for the Access Token? |
|
|
I mean, GitHub Developer Access Token permissions; What scopes? |
Assuming the token is fine-grained, Assuming the token is classic, |
|
Token created. It expires in 2026 (April 30) -- Name: cc @mcollina apparently the Node.js Enterprise sets a limit of how long tokens can last. Can we change that from a maximum of 366 days to no expiration? |
Signed-off-by: Aviv Keller <me@aviv.sh>
Signed-off-by: Aviv Keller <me@aviv.sh>
|
Lighthouse Results
|
|
FYI I've closed the currently open Crowdin PRs, and will make a new one once this lands. |
|
Fast tracking, as this doesn't change the execution of anything, only the permissions granted. |
The author of the PR cannot request for fast-tracking and approve the fast-tracking. So if you say requesting fast tracking, someone needs to give a 👍 first 🙈 |
|
😅 |
Ref: #7668
Ref: https://github.com/stefanzweifel/git-auto-commit-action#commits-made-by-this-action-do-not-trigger-new-workflow-runs