feat(fileprovider): solution to display integration in file provider using socket.

REUSE.toml

@@ -127,7 +127,7 @@ SPDX-FileCopyrightText = "2016 Nextcloud GmbH"
 SPDX-License-Identifier = "LicenseRef-NextcloudTrademarks"
 
 [[annotations]]
-path = ["theme/white/error.svg", "theme/black/error.svg","theme/white/warning.svg", "theme/black/warning.svg", "theme/white/info.svg", "theme/black/info.svg", "theme/info.svg", "theme/white/nextcloud/*.svg", "theme/black/nextcloud/*.svg", "theme/colored/nextcloud/*.svg", "theme/black/label.svg", "theme/white/label.svg", "theme/colored/user-status-*.svg", "theme/account.svg","theme/add.svg","theme/change.svg","theme/chevron-double-up.svg","theme/close.svg","theme/confirm.svg","theme/copy.svg","theme/delete.svg","theme/external.svg","theme/files.svg","theme/lock-broken.svg","theme/lock-http.svg","theme/lock-https.svg","theme/lock.svg","theme/magnifying-glass.svg","theme/more.svg","theme/network.svg","theme/public.svg","theme/reply.svg","theme/send.svg","theme/settings.svg","theme/share.svg","theme/sync-arrow.svg", "theme/black/account-group.svg","theme/black/clear.svg","theme/black/expand-less-black.svg","theme/black/folder-group.svg","theme/black/search.svg", "theme/colored/add-bordered.svg", "theme/colored/change-bordered.svg", "theme/colored/delete-bordered.svg", "theme/colored/delete.svg", "theme/*/activity.svg", "theme/*/add.svg","theme/*/bell.svg","theme/*/calendar.svg","theme/*/caret-down.svg","theme/*/change.svg","theme/*/close.svg","theme/*/comment.svg","theme/*/confirm.svg","theme/*/control-next.svg","theme/*/control-prev.svg","theme/*/edit.svg","theme/*/email.svg","theme/*/external.png","theme/*/external.svg","theme/*/external@2x.png","theme/*/folder.png","theme/*/folder.svg","theme/*/folder@2x.png","theme/*/more-apps.svg","theme/*/nc-assistant-app.svg","theme/*/settings.svg","theme/*/user.svg","theme/*/wizard-files.png","theme/*/wizard-files.svg","theme/*/wizard-files@2x.png","theme/*/wizard-groupware.png","theme/*/wizard-groupware.svg","theme/*/wizard-groupware@2x.png", "theme/cfapishellext_custom_states/0-locked.svg","theme/cfapishellext_custom_states/1-shared.svg","theme/cfapishellext_custom_states/1024-0-locked.png","theme/cfapishellext_custom_states/1024-1-shared.png","theme/cfapishellext_custom_states/128-0-locked.png","theme/cfapishellext_custom_states/128-1-shared.png","theme/cfapishellext_custom_states/24-0-locked.png","theme/cfapishellext_custom_states/24-1-shared.png","theme/cfapishellext_custom_states/256-0-locked.png","theme/cfapishellext_custom_states/256-1-shared.png","theme/cfapishellext_custom_states/32-0-locked.png","theme/cfapishellext_custom_states/32-1-shared.png","theme/cfapishellext_custom_states/40-0-locked.png","theme/cfapishellext_custom_states/40-1-shared.png","theme/cfapishellext_custom_states/48-0-locked.png","theme/cfapishellext_custom_states/48-1-shared.png","theme/cfapishellext_custom_states/512-0-locked.png","theme/cfapishellext_custom_states/512-1-shared.png","theme/cfapishellext_custom_states/64-0-locked.png","theme/cfapishellext_custom_states/64-1-shared.png"]
+path = ["theme/white/error.svg", "theme/black/error.svg","theme/white/warning.svg", "theme/black/warning.svg", "theme/white/info.svg", "theme/black/info.svg", "theme/info.svg", "theme/white/nextcloud/*.svg", "theme/black/nextcloud/*.svg", "theme/colored/nextcloud/*.svg", "theme/black/label.svg", "theme/white/label.svg", "theme/colored/user-status-*.svg", "theme/account.svg","theme/add.svg","theme/change.svg","theme/chevron-double-up.svg","theme/close.svg","theme/confirm.svg","theme/copy.svg","theme/delete.svg","theme/external.svg","theme/files.svg","theme/lock-broken.svg","theme/lock-http.svg","theme/lock-https.svg","theme/lock.svg","theme/magnifying-glass.svg","theme/more.svg","theme/network.svg","theme/public.svg","theme/reply.svg","theme/send.svg","theme/settings.svg","theme/share.svg","theme/sync-arrow.svg", "theme/black/account-group.svg","theme/black/clear.svg","theme/black/expand-less-black.svg","theme/black/folder-group.svg","theme/black/search.svg", "theme/colored/add-bordered.svg", "theme/colored/change-bordered.svg", "theme/colored/delete-bordered.svg", "theme/colored/delete.svg", "theme/*/activity.svg", "theme/*/add.svg","theme/*/bell.svg","theme/*/calendar.svg","theme/*/caret-down.svg","theme/*/change.svg","theme/*/close.svg","theme/*/comment.svg","theme/*/confirm.svg","theme/*/control-next.svg","theme/*/control-prev.svg","theme/*/edit.svg","theme/*/email.svg","theme/*/external.png","theme/*/external.svg","theme/*/external@2x.png","theme/*/folder.png","theme/*/folder.svg","theme/*/folder@2x.png","theme/*/more-apps.svg","theme/*/nc-assistant-app.svg","theme/*/settings.svg","theme/*/user.svg","theme/*/wizard-files.png","theme/*/wizard-files.svg","theme/*/wizard-files@2x.png","theme/*/wizard-groupware.png","theme/*/wizard-groupware.svg","theme/*/wizard-groupware@2x.png", "theme/cfapishellext_custom_states/0-locked.svg","theme/cfapishellext_custom_states/1-shared.svg","theme/cfapishellext_custom_states/1024-0-locked.png","theme/cfapishellext_custom_states/1024-1-shared.png","theme/cfapishellext_custom_states/128-0-locked.png","theme/cfapishellext_custom_states/128-1-shared.png","theme/cfapishellext_custom_states/24-0-locked.png","theme/cfapishellext_custom_states/24-1-shared.png","theme/cfapishellext_custom_states/256-0-locked.png","theme/cfapishellext_custom_states/256-1-shared.png","theme/cfapishellext_custom_states/32-0-locked.png","theme/cfapishellext_custom_states/32-1-shared.png","theme/cfapishellext_custom_states/40-0-locked.png","theme/cfapishellext_custom_states/40-1-shared.png","theme/cfapishellext_custom_states/48-0-locked.png","theme/cfapishellext_custom_states/48-1-shared.png","theme/cfapishellext_custom_states/512-0-locked.png","theme/cfapishellext_custom_states/512-1-shared.png","theme/cfapishellext_custom_states/64-0-locked.png","theme/cfapishellext_custom_states/64-1-shared.png", "theme/backup.svg", "theme/convert_to_text.svg", "theme/file-open.svg"]
 precedence = "aggregate"
 SPDX-FileCopyrightText = "2018-2025 Google LLC"
 SPDX-License-Identifier = "Apache-2.0"

resources.qrc

@@ -61,5 +61,6 @@
         <file>src/gui/ConflictItemFileInfo.qml</file>
         <file>src/gui/macOS/ui/FileProviderSettings.qml</file>
         <file>src/gui/macOS/ui/FileProviderFileDelegate.qml</file>
+        <file>src/gui/integration/FileActionsWindow.qml</file>
     </qresource>
 </RCC>

shell_integration/MacOSX/NextcloudFileProviderKit/Sources/NextcloudFileProviderKit/Extensions/FileManager+applicationGroupContainer.swift

@@ -18,10 +18,16 @@
             return nil
         }
 
-        guard let appGroupIdentifier = extensionDictionary["NSExtensionFileProviderDocumentGroup"] as? String else {
-            return nil
+        if let fileProviderGroupIdentifier = extensionDictionary["NSExtensionFileProviderDocumentGroup"] as? String,
+            !fileProviderGroupIdentifier.isEmpty {
+            return containerURL(forSecurityApplicationGroupIdentifier: fileProviderGroupIdentifier)
+        }
+
+        if let mainAppGroupIdentifier = Bundle.main.object(forInfoDictionaryKey: "SocketApiprefix") as? String,
+            !mainAppGroupIdentifier.isEmpty {
+            return containerURL(forSecurityApplicationGroupIdentifier: mainAppGroupIdentifier)
         }
 
-        return containerURL(forSecurityApplicationGroupIdentifier: appGroupIdentifier)
+        return nil
     }
 }

shell_integration/MacOSX/NextcloudIntegration/FileProviderUIExt/DocumentActionViewController.swift

@@ -2,6 +2,9 @@
 //  SPDX-License-Identifier: GPL-2.0-or-later
 
 import FileProviderUI
+import FileProvider
+import NCDesktopClientSocketKit
+import NextcloudKit
 import NextcloudFileProviderKit
 import OSLog
 
@@ -29,6 +32,9 @@ class DocumentActionViewController: FPUIActionExtensionViewController {
     var logger: FileProviderLogger!
 
     var serviceResolver: ServiceResolver!
+
+    var socketClient: LocalSocketClient?
+    lazy var lineProcessor: LineProcessor = NoOpLineProcessor()
 
     // MARK: - Lifecycle
 
@@ -44,6 +50,27 @@ class DocumentActionViewController: FPUIActionExtensionViewController {
         if serviceResolver == nil, let log {
             serviceResolver = ServiceResolver(log: log)
         }
+
+        setupSocketClientForSocketApi()
+    }
+
+    private func setupSocketClientForSocketApi() {
+        guard let socketApiPrefix = Bundle.main.object(forInfoDictionaryKey: "SocketApiPrefix") as? String, !socketApiPrefix.isEmpty else {
+            logger?.error("No SocketApiPrefix found")
+            return
+        }
+
+        guard let containerUrl = FileManager.default.containerURL(forSecurityApplicationGroupIdentifier: socketApiPrefix) else {
+            logger?.error("No containerURL available")
+            return
+        }
+
+        let socketPath = containerUrl.appendingPathComponent("s", isDirectory: true)
+        let processor = NoOpLineProcessor()
+// FIXME
+//        self.socketClient = LocalSocketClient(socketPath: socketPath.path, lineProcessor: processor)
+//        self.socketClient?.start()
+//        self.logger?.debug("Socket client started successfully")
     }
 
     func prepare(childViewController: NSViewController) {
@@ -73,6 +100,8 @@ class DocumentActionViewController: FPUIActionExtensionViewController {
             case "com.nextcloud.desktopclient.FileProviderUIExt.EvictAction":
                 evict(itemsWithIdentifiers: itemIdentifiers, inDomain: domain);
                 extensionContext.completeRequest();
+            case "com.nextcloud.desktopclient.FileProviderUIExt.FileActionsAction":
+                showFileActions(itemsWithIdentifiers: itemIdentifiers, inDomain: domain);
             default:
                 return
         }
@@ -129,4 +158,38 @@ class DocumentActionViewController: FPUIActionExtensionViewController {
 
         semaphore.wait()
     }
+
+    func showFileActions(itemsWithIdentifiers identifiers: [NSFileProviderItemIdentifier], inDomain domain: NSFileProviderDomain) {
+        guard let firstIdentifier = identifiers.first else {
+            logger?.error("No item identifiers provided.")
+            extensionContext.completeRequest()
+            return
+        }
+
+        Task {
+            do {
+                guard let manager = NSFileProviderManager(for: domain) else {
+                    logger?.error("Could not get file provider domain manager.")
+                    await MainActor.run { extensionContext.completeRequest() }
+                    return
+                }
+                let itemURL = try await manager.getUserVisibleURL(for: firstIdentifier)
+                let localPath = itemURL.path
+                let command = "FILE_ACTIONS:\(localPath)\n"
+// FIXME
+//                self.socketClient?.sendMessage(command)
+//                self.logger?.debug("FILE_ACTIONS sent for: \(localPath)")
+                await MainActor.run { extensionContext.completeRequest() }
+            } catch {
+                logger?.error("Error: \(error.localizedDescription)")
+                await MainActor.run { extensionContext.completeRequest() }
+            }
+        }
+    }
 }
+
+private final class NoOpLineProcessor: NSObject, LineProcessor {
+    func process(_ line: String) {
+    }
+}
+

shell_integration/MacOSX/NextcloudIntegration/FileProviderUIExt/Info.plist

@@ -21,6 +21,8 @@
 	<string>$(OC_APPLICATION_NAME) File Provider UI Extension</string>
 	<key>CFBundleIdentifier</key>
 	<string>$(OC_APPLICATION_REV_DOMAIN).$(PRODUCT_NAME)</string>
+    <key>SocketApiPrefix</key>
+    <string>$(DEVELOPMENT_TEAM).$(OC_APPLICATION_REV_DOMAIN)</string>
 	<key>NSExtension</key>
 	<dict>
 		<key>NSExtensionFileProviderActions</key>
@@ -57,6 +59,14 @@
 				<key>NSExtensionFileProviderActionName</key>
 				<string>Free up space</string>
 			</dict>
+            <dict>
+                <key>NSExtensionFileProviderActionActivationRule</key>
+                <string>SUBQUERY ( fileproviderItems, $fileproviderItem, $fileproviderItem.userInfo != nil ).@count &gt; 0</string>
+                <key>NSExtensionFileProviderActionIdentifier</key>
+                <string>com.nextcloud.desktopclient.FileProviderUIExt.FileActionsAction</string>
+                <key>NSExtensionFileProviderActionName</key>
+                <string>File Actions</string>
+            </dict>
 		</array>
 		<key>NSExtensionPointIdentifier</key>
 		<string>com.apple.fileprovider-actionsui</string>

src/gui/CMakeLists.txt

@@ -258,6 +258,8 @@ set(client_SRCS
     wizard/linklabel.cpp
     wizard/wizardproxysettingsdialog.h
     wizard/wizardproxysettingsdialog.cpp
+    integration/fileactionsmodel.h
+    integration/fileactionsmodel.cpp
     )
 
 if (NOT DISABLE_ACCOUNT_MIGRATION)

src/gui/application.cpp

@@ -1,3 +1,3 @@
 /*
  * SPDX-FileCopyrightText: 2017 Nextcloud GmbH and Nextcloud contributors
  * SPDX-FileCopyrightText: 2014 ownCloud GmbH
@@ -432,6 +432,9 @@
     connect(FolderMan::instance()->socketApi(), &SocketApi::fileActivityCommandReceived,
         _gui.data(), &ownCloudGui::slotShowFileActivityDialog);
 
+    connect(FolderMan::instance()->socketApi(), &SocketApi::fileActionsCommandReceived,
+            _gui.data(), &ownCloudGui::slotShowFileActionsDialog);
+
     // startup procedure.
     connect(&_checkConnectionTimer, &QTimer::timeout, this, &Application::slotCheckConnection);
     _checkConnectionTimer.setInterval(ConnectionValidator::DefaultCallingIntervalMsec); // check for connection every 32 seconds.