feat(fileprovider): solution to display integration in file provider using socket.#9461
Closed
feat(fileprovider): solution to display integration in file provider using socket.#9461
Conversation
- declarativeui: add endpoints model. - capabilities: fetch endpoints in capabilities. - display endpoints in an application window. - list file actions in context menu. - remove EndpointModel from DeclarativeUi class. - list declarative ui and file actions in the tray activitiy. - add icon and filter to endpoint model and UI. Signed-off-by: Camila Ayres <hello@camilasan.com>
- display response from request from file actions. Signed-off-by: Camila Ayres <hello@camilasan.com>
Signed-off-by: Camila Ayres <hello@camilasan.com>
- add helper function to match string to SimpleApiJob::Verb. - filter and display file actions based on the file mimetype. - adjust logic to get context menu by mimeType. - create function to set file id and mime type. - rename Endpoint to FileActions. Signed-off-by: Camila Ayres <hello@camilasan.com>
- improve error handling. - display a different icon for each mimetype. Signed-off-by: Camila Ayres <hello@camilasan.com>
…n't have one. - improve file actions window UI. Signed-off-by: Camila Ayres <hello@camilasan.com>
…ements like url. - add opacity mask and more spacing. - implement hover for the file action buttons. - fix logic to display error/success messages. - improve text for error/success messages. Signed-off-by: Camila Ayres <hello@camilasan.com>
The declarative ui in fact will be returned in the response from file actions. Signed-off-by: Camila Ayres <hello@camilasan.com>
Signed-off-by: Camila Ayres <hello@camilasan.com>
- use reference type in for loop. - fix spaces and sizes in the file actions window. - remove missing file from resources. Signed-off-by: Camila Ayres <hello@camilasan.com>
…etype check. Signed-off-by: Camila Ayres <hello@camilasan.com>
Signed-off-by: Camila Ayres <hello@camilasan.com>
…lable to all mimetypes. Signed-off-by: Camila Ayres <hello@camilasan.com>
Signed-off-by: Camila Ayres <hello@camilasan.com>
- remove DeclarativeUi files. - add return default value in switch. - add const. Signed-off-by: Camila Ayres <hello@camilasan.com>
…on map. Signed-off-by: Camila Ayres <hello@camilasan.com>
…port it. Signed-off-by: Camila Ayres <hello@camilasan.com>
Signed-off-by: Camila Ayres <hello@camilasan.com>
Signed-off-by: Camila Ayres <hello@camilasan.com>
Signed-off-by: Camila Ayres <hello@camilasan.com>
…ize. Signed-off-by: Camila Ayres <hello@camilasan.com>
Signed-off-by: Camila Ayres <hello@camilasan.com>
Signed-off-by: Camila Ayres <hello@camilasan.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| void setResponse(const Response &response); | ||
|
|
||
| void parseEndpoints(); | ||
| QString parseUrl(const QString &url) const; |
There was a problem hiding this comment.
function parseUrl should be marked [[nodiscard]]
Suggested change
| QString parseUrl(const QString &url) const; | |
| [[nodiscard]] QString parseUrl(const QString &url) const; |
|
|
||
| void parseEndpoints(); | ||
| QString parseUrl(const QString &url) const; | ||
| QString parseIcon(const QString &icon) const; |
There was a problem hiding this comment.
function parseIcon should be marked [[nodiscard]]
Suggested change
| QString parseIcon(const QString &icon) const; | |
| [[nodiscard]] QString parseIcon(const QString &icon) const; |
The use of LocalSocketClient doesn't work. File actions are listed in the context menu but FileProviderUIExt doesn't start. Signed-off-by: Camila Ayres <hello@camilasan.com>
camilasan
force-pushed
the
feature/socket
branch
from
d3a128b to
82def6c
Compare
|
Artifact containing the AppImage: nextcloud-appimage-pr-9461.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
Collaborator
|
The UNIX sockets will be replaced soon with XPC calls. |
|
Collaborator
|
Closed in favor of #9469. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solution to display integration in file provider using socket (LocalSocketClient).
The use of LocalSocketClient doesn't work.
File actions are listed in the context menu but FileProviderUIExt doesn't start.
See xpc solution option at #9458.
Related to #9403.