Skip to content

feat: exchange cloud ID #4417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
redblom wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

feat: exchange cloud ID #4417

redblom wants to merge 3 commits into from

Conversation

@redblom
Copy link

@redblom redblom commented Apr 8, 2025 •
edited
Loading

This is a work in progress
This PR implements #4416

@hamza221 hamza221 added enhancement New feature or request 2. developing Work in progress labels Apr 8, 2025
@hamza221 hamza221 marked this pull request as draft April 8, 2025 09:14
@redblom
Copy link
Author

redblom commented Apr 8, 2025 •
edited
Loading

General layout plan:

  • dedicated button to send an invite to a remote user - below 'New contact' button
  • dedicated button on cloud ID component for existing remote contacts that have no cloud ID set
  • new sent invites will be displayed in the left panel - with a revoke option

Status:

  • invite accept dialog route implemented

@hamza221 hamza221 added this to the v7.1.0 milestone Apr 10, 2025
@redblom redblom force-pushed the invite-for-cloudid-exchange branch from ea81812 to 7c0eaa0 Compare April 10, 2025 20:45
@github-actions
Copy link

github-actions bot commented Apr 23, 2025

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@codecov
Copy link

codecov bot commented Apr 24, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 1.07296% with 461 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/views/Contacts.vue 0.00% 98 Missing ⚠️
src/store/ocminvites.js 8.62% 52 Missing and 1 partial ⚠️
src/components/Ocm/OcmAcceptForm.vue 0.00% 52 Missing ⚠️
src/components/Ocm/OcmInvitesList.vue 0.00% 51 Missing ⚠️
src/components/Ocm/OcmInviteDetails.vue 0.00% 50 Missing ⚠️
src/components/Ocm/Wayf.vue 0.00% 45 Missing ⚠️
src/components/AppContent/OcmInvitesContent.vue 0.00% 33 Missing ⚠️
src/components/Ocm/OcmInviteForm.vue 0.00% 18 Missing ⚠️
src/components/AppNavigation/RootNavigation.vue 0.00% 17 Missing ⚠️
src/components/Ocm/OcmInviteAccept.vue 0.00% 14 Missing ⚠️
... and 7 more

📢 Thoughts on this report? Let us know!

@ChristophWurst
Copy link
Member

ChristophWurst commented Apr 25, 2025

Thanks for the contribution, @redblom!

The features relies on an implementation of the Invitation Workflow (see https://github.com/sara-nl/nc-collaboration).

Is there any way this could work without introducing an app dependency?

@hamza221 hamza221 modified the milestones: v7.1.0, v7.2.0 Apr 28, 2025
@redblom
Copy link
Author

redblom commented Apr 29, 2025 •
edited
Loading

Thanks for the contribution, @redblom!

The features relies on an implementation of the Invitation Workflow (see https://github.com/sara-nl/nc-collaboration).

Is there any way this could work without introducing an app dependency?

Short answer: No, that is to say, the actual cloud ID exchange is not a responsibility of the contacts app but the contacts app (the cloud ID field) is a logical place where to have this option (as per earlier discussion with the Design Team).
The feature actually depends on the implementation of OCM /invite-accepted. This is currently in the process of being implemented for nextcloud server core (nextcloud/server#51113) so cloud ID exchange can become an integral part of nextcloud. Up until then there should be an app present implementing this.
The idea is to make the option not visible to the user when the platform can not do the actual cloud ID exchange (by configuration).
(so the best answer is: yes, when cloud ID exchange has become an integral part of nextcloud :)

@redblom redblom force-pushed the invite-for-cloudid-exchange branch 2 times, most recently from 0112a78 to e7c2604 Compare April 30, 2025 14:32
@ChristophWurst
Copy link
Member

ChristophWurst commented Apr 30, 2025

Thanks for the clarification

@ChristophWurst ChristophWurst requested review from ArtificialOwl and removed request for GVodyanov, SebastianKrupinski and hamza221 May 15, 2025 12:09
@redblom redblom force-pushed the invite-for-cloudid-exchange branch 5 times, most recently from 76d6df3 to ca42433 Compare June 18, 2025 14:33
@redblom redblom force-pushed the invite-for-cloudid-exchange branch from ca42433 to 62ce0c2 Compare June 26, 2025 08:21
@redblom redblom force-pushed the invite-for-cloudid-exchange branch 3 times, most recently from 9f0bca4 to 55647b8 Compare September 25, 2025 12:36
@mickenordin
Copy link

mickenordin commented Sep 25, 2025

Adding some screenshots here to show you what it looks like, this is the dialog for adding a new invitation:
2025-09-25T16:01:24,021984991+02:00
This is what it looks like after it is sent:
2025-09-25T16:01:40,518818898+02:00
This is the default Where-Are-You-From page, when no federation has been configured
2025-09-25T16:05:10,821218256+02:00
This is what the WAYF-page looks like with a federation configured:
2025-09-25T16:06:40,570032364+02:00
It is also possible to add multiple federations:
2025-09-25T16:14:34,777039486+02:00
This is what the type-to-search feature looks like:
2025-09-25T16:14:50,748780755+02:00

@mickenordin
Copy link

mickenordin commented Sep 25, 2025

Thanks for the contribution, @redblom!

The features relies on an implementation of the Invitation Workflow (see https://github.com/sara-nl/nc-collaboration).

Is there any way this could work without introducing an app dependency?

All the necessary plumbing is in Nextcloud 32.0.0.0rc4 so no external apps needed anymore.

@redblom redblom changed the title [WIP] exchange cloud ID feat: exchange cloud ID Sep 26, 2025
@redblom redblom marked this pull request as ready for review September 26, 2025 08:20
@redblom redblom force-pushed the invite-for-cloudid-exchange branch from 55647b8 to 20fc781 Compare September 26, 2025 08:52
@ChristophWurst ChristophWurst added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Sep 26, 2025
@redblom redblom force-pushed the invite-for-cloudid-exchange branch 3 times, most recently from e51a605 to 153fdb1 Compare October 3, 2025 09:39
@redblom redblom force-pushed the invite-for-cloudid-exchange branch from 3fba972 to f9574de Compare October 13, 2025 16:16
@redblom redblom force-pushed the invite-for-cloudid-exchange branch from 26a76f8 to 2272c9f Compare October 29, 2025 15:05
@redblom
Copy link
Author

redblom commented Oct 29, 2025

@ArtificialOwl could you give it a go, the review.

ArtificialOwl
ArtificialOwl reviewed Nov 17, 2025
View reviewed changes
Copy link
Member

@ArtificialOwl ArtificialOwl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quick review, not fully complete, but already some elements to rework

@redblom redblom force-pushed the invite-for-cloudid-exchange branch from 069d061 to 86027f9 Compare November 20, 2025 15:48
@redblom redblom force-pushed the invite-for-cloudid-exchange branch from 280c35f to 7a8cc14 Compare January 13, 2026 08:41
@redblom redblom force-pushed the invite-for-cloudid-exchange branch from 7a8cc14 to d6a02e3 Compare January 23, 2026 16:13
@redblom redblom closed this Jan 26, 2026
@redblom redblom force-pushed the invite-for-cloudid-exchange branch from d6a02e3 to 9b66ad3 Compare January 26, 2026 07:52
@redblom @mickenordin
feat(OCM-Invites): Implement exchanging cloud IDs through OCM invitat…
abfaefe 
…ion workflow

see https://github.com/cs3org/OCM-API/blob/v1.2.1/IETF-RFC.md
Features:
 - Button to invite remote users to exchange cloudIDs.
 - Button to manually accept invite to exchange cloudIDs.
 - WAYF page allowing the receiver of the invite to open and accept the invitation.
 - Listing of open invitations.
 - Option to resend, revoke open invitations.

Signed-off-by: antoonp <antoon@redblom.com>
Co-authored-by: Micke Nordin <kano@sunet.se>
@redblom redblom reopened this Jan 26, 2026
@redblom
Copy link
Author

redblom commented Jan 26, 2026

@ArtificialOwl modified to work with Nextcloud 33 OCM endpoint request event.

@redblom redblom marked this pull request as draft January 27, 2026 08:46
@redblom
Copy link
Author

redblom commented Jan 27, 2026 •
edited
Loading

List of modifications - basically moving everything around the invite-accepted capability to this app:

  • move implementation of invite-accepted capability to this app - done
  • move registering invite-accepted capability to this app - done
  • move setting/getting InviteAcceptDialog property to this app

@redblom redblom mentioned this pull request Jan 27, 2026
Draft
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ArtificialOwl ArtificialOwl ArtificialOwl left review comments

@hamza221 hamza221 Awaiting requested review from hamza221 hamza221 will be requested when the pull request is marked ready for review hamza221 is a code owner

@SebastianKrupinski SebastianKrupinski Awaiting requested review from SebastianKrupinski SebastianKrupinski will be requested when the pull request is marked ready for review SebastianKrupinski is a code owner

@GVodyanov GVodyanov Awaiting requested review from GVodyanov GVodyanov will be requested when the pull request is marked ready for review GVodyanov is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@redblom redblom

Labels

3. to review Waiting for reviews enhancement New feature or request feedback-requested

Projects

None yet

Milestone

v7.2.0

Development

Successfully merging this pull request may close these issues.

5 participants

@redblom @ChristophWurst @mickenordin @ArtificialOwl @hamza221