Move invite-accepted capability and implementation to contacts app.

[redblom]

• Resolves: #

Summary

Code moved to contacts app, see nextcloud/contacts#4417

TODO

• deal with inviteAcceptedDialog code

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)
• Labels added where applicable (ex: bug/enhancement, 3. to review, feature component)
• Milestone added for target branch/version (ex: 32.x for stable32)

[ChristophWurst]

@redblom why is this moved out of server and could it break OCM when the contacts app is not installed? the app is not shipped. it is optional.

[ArtificialOwl]

@redblom why is this moved out of server and could it break OCM when the contacts app is not installed? the app is not shipped. it is optional.

This is done on my request:

• it is moved out of server because the implementation of the feature creates its own db table and does not provide an API to manage it,
• it will not break OCM, it will only not enable the 'invite-accepted' capability if contacts is not installed. the capability is useless without the contacts app,
• contacts will register the capability and fully manage the db table

[ArtificialOwl]

let's ping @mickenordin on this one !

[mickenordin]

let's ping @mickenordin on this one !

I haven't reviewed the change, but in principal I see no problem with it.

[redblom]

Rebased, squashed, removed draft label.

[github-actions]

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

[miaulalala]

Hey @redblom , can you do the following things?

• Fetch current master - git fetch origin (if your remote is not called origin, replace it with whatever your remote name is)
• Squash your commits into a single one, and add a signoff
  • The easiest way is using git reset --soft origin/master - this will reset your branch to master but leave all your changes as staged files so nothing is lost. It removes your commit history, but not your file changes.
• Run composer cs:fix to autofix the PHP linting issues
• Then you can do your usual git add (I like using git add -p to check my changes in chunks within a diff view, but you do you 😉 ) to stage your lint fixes
• Use `git commit -sm "fix: your message here" to signoff your commit
• push to your branch
• Ping me and I'll enable the workflows

ETA: you can do the same workflow on the contacts branch too

[redblom]

* [ ]  Ping me and I'll enable the workflows

@miaulalala - ping !

[miaulalala]

@ArtificialOwl can you review? CI is fine now, only workflows not allowed on forks are red.

[artonge]

We need to document this here: https://github.com/nextcloud/documentation/blob/master/developer_manual/app_publishing_maintenance/app_upgrade_guide/upgrade_to_34.rst#added-apis-1

[redblom]

The idea is to backport to stable 33 once this is merged. So add to .../upgrade_to_33rst instead ?

[artonge]

Yes, but I am not sure that we'll backport that to 33 as this is not really critical.

[redblom]

We need to document this here: https://github.com/nextcloud/documentation/blob/master/developer_manual/app_publishing_maintenance/app_upgrade_guide/upgrade_to_34.rst#added-apis-1

See nextcloud/documentation#14662

[miaulalala]

can you run composer openapi and squash your commit history?

[redblom]

@artonge, @nickvergessen - I believe it's all there now. Can you check/review?

[sorbaugh]

/backport to stable33

[miaulalala]

Hi @redblom! There are two CI failures to fix:

1. Autoloaders out of date
Run bash build/autoloaderchecker.sh from the repo root, then commit the updated autoloader files.

2. Psalm config references a removed directory
psalm.xml still references apps/cloud_federation_api/tests, which appears to have been removed by this PR. Run composer psalm:update-baseline to regenerate the baseline and commit the result.

After both fixes, please squash your commits into a single signed-off commit and push.

[redblom]

@miaulalala - I can't seem to open the logs of where https://github.com/nextcloud/server/actions/runs/26154330166/job/76951001122?pr=57853 has failed. The run looks like it's stuck ...
Do you have any more info?