Skip to content

Fix slow file list loading when entering a directory for the first time with 1000+ files. #17104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
berlin2123 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix slow file list loading when entering a directory for the first time with 1000+ files. #17104

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
65dc40f
skip per-file database lookup on first folder sync
berlin2123 May 30, 2026
01f42c5
Merge branch 'master' into patch-1
berlin2123 May 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion app/src/main/java/com/owncloud/android/operations/RefreshFolderOperation.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -569,6 +569,8 @@ private void synchronizeData(List<Object> folderAndFiles) {
OCFile updatedFile;
RemoteFile remote;

final boolean skipGetFileByPath = localFilesMap.isEmpty();

for (int i = 1; i < folderAndFiles.size(); i++) {
/// new OCFile instance with the data from the server
remote = (RemoteFile) folderAndFiles.get(i);
Expand All @@ -582,7 +584,7 @@ private void synchronizeData(List<Object> folderAndFiles) {
localFile = localFilesMap.remove(remoteFile.getRemotePath());

// TODO better implementation is needed
if (localFile == null) {
if (localFile == null && !skipGetFileByPath) {
localFile = fileDataStorageManager.getFileByPath(updatedFile.getRemotePath());
}

Expand Down