Fix slow file list loading when entering a directory for the first time with 1000+ files.#17104
Open
berlin2123 wants to merge 2 commits into
Open
Fix slow file list loading when entering a directory for the first time with 1000+ files.#17104berlin2123 wants to merge 2 commits into
berlin2123 wants to merge 2 commits into
Conversation
When syncing a folder with many files for the first time, each remote file triggered a ContentProvider getFileByPath() query. For a directory with 1000+ files, this meant 1000+ individual database lookups — all of which returned null because the files did not exist locally yet. Skip the per-file fallback when localFilesMap is empty, since no local state exists to merge. Signed-off-by: berlin2123 <68841407+berlin2123@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When syncing a folder with many files for the first time, each remote file triggered a ContentProvider getFileByPath() query. For a directory with 1000+ files, this meant 1000+ individual database lookups — all of which returned null because the files did not exist locally yet.
Skip the per-file fallback when localFilesMap is empty, since no local state exists to merge.
🏁 Checklist