Skip to content

fix: Remove js file from dist and use only provide Typescript definitions#242

Merged
susnux merged 1 commit intomainfrom
chore/drop-js-from-dist
Mar 17, 2026
Merged

fix: Remove js file from dist and use only provide Typescript definitions#242
susnux merged 1 commit intomainfrom
chore/drop-js-from-dist

Conversation

@susnux
Copy link
Copy Markdown
Contributor

@susnux susnux commented Nov 29, 2023

No description provided.

Copy link
Copy Markdown
Contributor

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smells like a breaking change?

@susnux
Copy link
Copy Markdown
Contributor Author

susnux commented Dec 3, 2023

Smells like a breaking change?

Could be (should not break but could be). So I would like to include #241 and then release 1.8 and do this for 2.0 afterwards?

@ChristophWurst
Copy link
Copy Markdown
Contributor

Sounds good

…ions

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the chore/drop-js-from-dist branch from dec9f00 to ea4100d Compare November 6, 2025 22:29
@susnux susnux requested a review from ShGKme November 6, 2025 22:29
Comment thread tsconfig.json
"include": [
"lib"
],
]
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing coma is valid here

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only for jsonc

@susnux susnux merged commit 4212400 into main Mar 17, 2026
6 checks passed
@susnux susnux deleted the chore/drop-js-from-dist branch March 17, 2026 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants