Skip to content

Conversation

@susnux
Copy link
Contributor

@susnux susnux commented Jul 1, 2024

Brace yourself the diff is huge!
This is a complete refactor of the library and contains this changes:

  1. (breaking!) Make the package use modules instead of namespaces, this is the recommended way since ES modules are part of the language. This also fixes some weird behavior of referencing types with Typescript 5.5. Moreover this allows to separate the code better and reuse parts that we use later (probably) for new versions.
  2. Consolidate all types into Nextcloud28 as this is the oldest supported version. This allows to cleanup the code a bit.
  3. Add NextcloudLatest alias type export
  4. Use ESLint for code linting
  5. Use Prettier to enforce consistent code style
  6. Add SPDX headers and make package REUSE compliant

@AndyScherzinger
Copy link
Contributor

Add SPDX headers and make package REUSE compliant

Already on master @susnux - you might want to rebase

@susnux
Copy link
Contributor Author

susnux commented Jul 8, 2024

@AndyScherzinger thank you, done :)

@susnux susnux force-pushed the types-only branch 2 times, most recently from a29f7cb to 52e79ac Compare July 8, 2024 15:37
Copy link
Contributor

@AndyScherzinger AndyScherzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
… modules instead of namespaces

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
Copy link
Contributor Author

susnux commented Nov 7, 2025

Still WIP - I try to improve UX for developers (but this still works - just try to make it more convinient)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants