Add vehicle-upgrade for engineRequestModel
#4603
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FileEX
requested changes
Jan 6, 2026
FileEX
requested changes
Jan 6, 2026
FileEX
reviewed
Jan 17, 2026
Comment on lines
+466
to
+474
| auto* upgradeModelInfo = g_pGame->GetModelInfo(us); | ||
| if (upgradeModelInfo && upgradeModelInfo->GetParentID() != 0) | ||
| { | ||
| unsigned short parentID = upgradeModelInfo->GetParentID(); | ||
| if (IsUpgrade(parentID)) | ||
| { | ||
| us = parentID; | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
What do you think about moving this into a separate helper function to avoid redundancy here and in IsCompatibleUpgrade?
Contributor
Author
There was a problem hiding this comment.
Good idea, i will do it tomorrow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds option for requesting infinite vehicle upgrades like: wheels, spoilers etc.
Upgrade type is based on parent ID and will work same as default.
Test resource:
custom_upgrades.zip