Skip to content

wip #2988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
comandeo-mongo wants to merge 1 commit into from
+16 −5
Closed

wip #2988

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 16 additions & 5 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,33 +24,44 @@ jobs:
uses: actions/checkout@v2
with:
submodules: recursive
- id: start-mongodb
name: start mongodb
uses: mongodb-labs/drivers-evergreen-tools@master

- uses: actions/setup-python@v6
with:
python-version: '3.13'
Comment on lines +29 to +30
Copy link

Copilot AI Feb 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The indentation of the "with" keyword is incorrect. In GitHub Actions YAML, the "with" keyword should be aligned with "uses" (both at the same indentation level, not nested further).

Suggested change
with:
python-version: '3.13'
with:
python-version: '3.13'

Copilot uses AI. Check for mistakes.

- name: "Set up MongoDB"
id: setup-mongodb
uses: ./tests/drivers-evergreen-tools
Copy link

Copilot AI Feb 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The path to the drivers-evergreen-tools action is incorrect. According to .gitmodules, the submodule is located at ".mod/drivers-evergreen-tools", not "tests/drivers-evergreen-tools". The correct path should be "./mod/drivers-evergreen-tools" (note: without the leading dot in the submodule path).

Suggested change
uses: ./tests/drivers-evergreen-tools
uses: ./mod/drivers-evergreen-tools

Copilot uses AI. Check for mistakes.
with:
version: "${{matrix.mongodb}}"
topology: "${{matrix.topology}}"
version: ${{ matrix.mongodb }}
topology: ${{ matrix.topology }}

- name: load ruby
uses: ruby/setup-ruby@v1
with:
ruby-version: "${{matrix.ruby}}"
bundler: 2

- name: bundle
run: bundle install --jobs 4 --retry 3

- name: prepare test suite
run: bundle exec rake spec:prepare
env:
MONGODB_URI: ${{ steps.start-mongodb.outputs.cluster-uri }}
Copy link

Copilot AI Feb 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The step ID was changed from "start-mongodb" to "setup-mongodb" on line 33, but this step reference still uses the old ID "start-mongodb". This needs to be updated to "setup-mongodb" to match the new step ID.

Copilot uses AI. Check for mistakes.

- name: prepare replica set
run: ruby -Ilib -I.evergreen/lib -rbundler/setup -rserver_setup -e ServerSetup.new.setup_tags
if: ${{ matrix.topology == 'replica_set' }}
env:
MONGODB_URI: ${{ steps.start-mongodb.outputs.cluster-uri }}
Copy link

Copilot AI Feb 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The step ID was changed from "start-mongodb" to "setup-mongodb" on line 33, but this step reference still uses the old ID "start-mongodb". This needs to be updated to "setup-mongodb" to match the new step ID.

Copilot uses AI. Check for mistakes.

- name: wait for sessions
run: bundle exec rake spec:wait_for_sessions
if: ${{ matrix.topology == 'sharded_cluster' && matrix.mongodb == '3.6' }}
env:
MONGODB_URI: ${{ steps.start-mongodb.outputs.cluster-uri }}
Copy link

Copilot AI Feb 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The step ID was changed from "start-mongodb" to "setup-mongodb" on line 33, but this step reference still uses the old ID "start-mongodb". This needs to be updated to "setup-mongodb" to match the new step ID.

Copilot uses AI. Check for mistakes.

- name: test
timeout-minutes: 60
continue-on-error: false
Expand Down
Loading