Conversation
There was a problem hiding this comment.
Pull request overview
This pull request updates the GitHub Actions workflow for running driver tests. The changes attempt to modernize the MongoDB setup step and add Python support, but contain several critical bugs that will prevent the workflow from executing successfully.
Changes:
- Added Python 3.13 setup step to support Python-dependent tests (e.g., OCSP tests)
- Changed MongoDB setup step to use a local action instead of the remote mongodb-labs action
- Renamed the MongoDB setup step ID from "start-mongodb" to "setup-mongodb"
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| - name: "Set up MongoDB" | ||
| id: setup-mongodb | ||
| uses: ./tests/drivers-evergreen-tools |
There was a problem hiding this comment.
The path to the drivers-evergreen-tools action is incorrect. According to .gitmodules, the submodule is located at ".mod/drivers-evergreen-tools", not "tests/drivers-evergreen-tools". The correct path should be "./mod/drivers-evergreen-tools" (note: without the leading dot in the submodule path).
| uses: ./tests/drivers-evergreen-tools | |
| uses: ./mod/drivers-evergreen-tools |
| - name: prepare test suite | ||
| run: bundle exec rake spec:prepare | ||
| env: | ||
| MONGODB_URI: ${{ steps.start-mongodb.outputs.cluster-uri }} |
There was a problem hiding this comment.
The step ID was changed from "start-mongodb" to "setup-mongodb" on line 33, but this step reference still uses the old ID "start-mongodb". This needs to be updated to "setup-mongodb" to match the new step ID.
| run: ruby -Ilib -I.evergreen/lib -rbundler/setup -rserver_setup -e ServerSetup.new.setup_tags | ||
| if: ${{ matrix.topology == 'replica_set' }} | ||
| env: | ||
| MONGODB_URI: ${{ steps.start-mongodb.outputs.cluster-uri }} |
There was a problem hiding this comment.
The step ID was changed from "start-mongodb" to "setup-mongodb" on line 33, but this step reference still uses the old ID "start-mongodb". This needs to be updated to "setup-mongodb" to match the new step ID.
| run: bundle exec rake spec:wait_for_sessions | ||
| if: ${{ matrix.topology == 'sharded_cluster' && matrix.mongodb == '3.6' }} | ||
| env: | ||
| MONGODB_URI: ${{ steps.start-mongodb.outputs.cluster-uri }} |
There was a problem hiding this comment.
The step ID was changed from "start-mongodb" to "setup-mongodb" on line 33, but this step reference still uses the old ID "start-mongodb". This needs to be updated to "setup-mongodb" to match the new step ID.
| with: | ||
| python-version: '3.13' |
There was a problem hiding this comment.
The indentation of the "with" keyword is incorrect. In GitHub Actions YAML, the "with" keyword should be aligned with "uses" (both at the same indentation level, not nested further).
| with: | |
| python-version: '3.13' | |
| with: | |
| python-version: '3.13' |
No description provided.