-
Notifications
You must be signed in to change notification settings - Fork 13.2k
Fix private properties not being allowed in optional chains #60263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Psychpsyo
wants to merge
3
commits into
microsoft:main
Choose a base branch
from
Psychpsyo:allow-private-property-in-optional-chain
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
40 changes: 40 additions & 0 deletions
40
tests/baselines/reference/privateIdentifierChain.1(target=es2015).errors.txt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| privateIdentifierChain.1.ts(23,17): error TS18013: Property '#b' is not accessible outside class 'A' because it has a private identifier. | ||
| privateIdentifierChain.1.ts(24,17): error TS18013: Property '#b' is not accessible outside class 'A' because it has a private identifier. | ||
| privateIdentifierChain.1.ts(25,22): error TS18013: Property '#b' is not accessible outside class 'A' because it has a private identifier. | ||
|
|
||
|
|
||
| ==== privateIdentifierChain.1.ts (3 errors) ==== | ||
| class A { | ||
| a?: A | ||
| #b?: A; | ||
| getA(): A { | ||
| return new A(); | ||
| } | ||
| constructor() { | ||
| this.a = this; | ||
| // None of these should error | ||
| this?.#b; | ||
| this?.a.#b; | ||
| this?.getA().#b; | ||
| } | ||
| } | ||
|
|
||
| class B { | ||
| a?: A | ||
| getA(): A { | ||
| return new A(); | ||
| } | ||
| constructor() { | ||
| this.a = new A(); | ||
| this.a?.#b; // Error | ||
| ~~ | ||
| !!! error TS18013: Property '#b' is not accessible outside class 'A' because it has a private identifier. | ||
| this?.a.#b; // Error | ||
| ~~ | ||
| !!! error TS18013: Property '#b' is not accessible outside class 'A' because it has a private identifier. | ||
| this?.getA().#b; // Error | ||
| ~~ | ||
| !!! error TS18013: Property '#b' is not accessible outside class 'A' because it has a private identifier. | ||
| } | ||
| } | ||
|
|
66 changes: 66 additions & 0 deletions
66
tests/baselines/reference/privateIdentifierChain.1(target=es2015).js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,66 @@ | ||
| //// [tests/cases/conformance/expressions/optionalChaining/privateIdentifierChain/privateIdentifierChain.1.ts] //// | ||
|
|
||
| //// [privateIdentifierChain.1.ts] | ||
| class A { | ||
| a?: A | ||
| #b?: A; | ||
| getA(): A { | ||
| return new A(); | ||
| } | ||
| constructor() { | ||
| this.a = this; | ||
| // None of these should error | ||
| this?.#b; | ||
| this?.a.#b; | ||
| this?.getA().#b; | ||
| } | ||
| } | ||
|
|
||
| class B { | ||
| a?: A | ||
| getA(): A { | ||
| return new A(); | ||
| } | ||
| constructor() { | ||
| this.a = new A(); | ||
| this.a?.#b; // Error | ||
| this?.a.#b; // Error | ||
| this?.getA().#b; // Error | ||
| } | ||
| } | ||
|
|
||
|
|
||
| //// [privateIdentifierChain.1.js] | ||
| "use strict"; | ||
| var __classPrivateFieldGet = (this && this.__classPrivateFieldGet) || function (receiver, state, kind, f) { | ||
| if (kind === "a" && !f) throw new TypeError("Private accessor was defined without a getter"); | ||
| if (typeof state === "function" ? receiver !== state || !f : !state.has(receiver)) throw new TypeError("Cannot read private member from an object whose class did not declare it"); | ||
| return kind === "m" ? f : kind === "a" ? f.call(receiver) : f ? f.value : state.get(receiver); | ||
| }; | ||
| var _A_b; | ||
| class A { | ||
| getA() { | ||
| return new A(); | ||
| } | ||
| constructor() { | ||
| _A_b.set(this, void 0); | ||
| this.a = this; | ||
| // None of these should error | ||
| __classPrivateFieldGet(this, _A_b, "f"); | ||
| __classPrivateFieldGet(this === null || this === void 0 ? void 0 : this.a, _A_b, "f"); | ||
| __classPrivateFieldGet(this === null || this === void 0 ? void 0 : this.getA(), _A_b, "f"); | ||
| } | ||
| } | ||
| _A_b = new WeakMap(); | ||
| class B { | ||
| getA() { | ||
| return new A(); | ||
| } | ||
| constructor() { | ||
| var _a; | ||
| this.a = new A(); | ||
| (_a = this.a) === null || _a === void 0 ? void 0 : _a.; // Error | ||
| this === null || this === void 0 ? void 0 : this.a.; // Error | ||
| this === null || this === void 0 ? void 0 : this.getA().; // Error | ||
| } | ||
| } |
85 changes: 85 additions & 0 deletions
85
tests/baselines/reference/privateIdentifierChain.1(target=es2015).symbols
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,85 @@ | ||
| //// [tests/cases/conformance/expressions/optionalChaining/privateIdentifierChain/privateIdentifierChain.1.ts] //// | ||
|
|
||
| === privateIdentifierChain.1.ts === | ||
| class A { | ||
| >A : Symbol(A, Decl(privateIdentifierChain.1.ts, 0, 0)) | ||
|
|
||
| a?: A | ||
| >a : Symbol(A.a, Decl(privateIdentifierChain.1.ts, 0, 9)) | ||
| >A : Symbol(A, Decl(privateIdentifierChain.1.ts, 0, 0)) | ||
|
|
||
| #b?: A; | ||
| >#b : Symbol(A.#b, Decl(privateIdentifierChain.1.ts, 1, 9)) | ||
| >A : Symbol(A, Decl(privateIdentifierChain.1.ts, 0, 0)) | ||
|
|
||
| getA(): A { | ||
| >getA : Symbol(A.getA, Decl(privateIdentifierChain.1.ts, 2, 11)) | ||
| >A : Symbol(A, Decl(privateIdentifierChain.1.ts, 0, 0)) | ||
|
|
||
| return new A(); | ||
| >A : Symbol(A, Decl(privateIdentifierChain.1.ts, 0, 0)) | ||
| } | ||
| constructor() { | ||
| this.a = this; | ||
| >this.a : Symbol(A.a, Decl(privateIdentifierChain.1.ts, 0, 9)) | ||
| >this : Symbol(A, Decl(privateIdentifierChain.1.ts, 0, 0)) | ||
| >a : Symbol(A.a, Decl(privateIdentifierChain.1.ts, 0, 9)) | ||
| >this : Symbol(A, Decl(privateIdentifierChain.1.ts, 0, 0)) | ||
|
|
||
| // None of these should error | ||
| this?.#b; | ||
| >this?.#b : Symbol(A.#b, Decl(privateIdentifierChain.1.ts, 1, 9)) | ||
| >this : Symbol(A, Decl(privateIdentifierChain.1.ts, 0, 0)) | ||
|
|
||
| this?.a.#b; | ||
| >this?.a.#b : Symbol(A.#b, Decl(privateIdentifierChain.1.ts, 1, 9)) | ||
| >this?.a : Symbol(A.a, Decl(privateIdentifierChain.1.ts, 0, 9)) | ||
| >this : Symbol(A, Decl(privateIdentifierChain.1.ts, 0, 0)) | ||
| >a : Symbol(A.a, Decl(privateIdentifierChain.1.ts, 0, 9)) | ||
|
|
||
| this?.getA().#b; | ||
| >this?.getA().#b : Symbol(A.#b, Decl(privateIdentifierChain.1.ts, 1, 9)) | ||
| >this?.getA : Symbol(A.getA, Decl(privateIdentifierChain.1.ts, 2, 11)) | ||
| >this : Symbol(A, Decl(privateIdentifierChain.1.ts, 0, 0)) | ||
| >getA : Symbol(A.getA, Decl(privateIdentifierChain.1.ts, 2, 11)) | ||
| } | ||
| } | ||
|
|
||
| class B { | ||
| >B : Symbol(B, Decl(privateIdentifierChain.1.ts, 13, 1)) | ||
|
|
||
| a?: A | ||
| >a : Symbol(B.a, Decl(privateIdentifierChain.1.ts, 15, 9)) | ||
| >A : Symbol(A, Decl(privateIdentifierChain.1.ts, 0, 0)) | ||
|
|
||
| getA(): A { | ||
| >getA : Symbol(B.getA, Decl(privateIdentifierChain.1.ts, 16, 9)) | ||
| >A : Symbol(A, Decl(privateIdentifierChain.1.ts, 0, 0)) | ||
|
|
||
| return new A(); | ||
| >A : Symbol(A, Decl(privateIdentifierChain.1.ts, 0, 0)) | ||
| } | ||
| constructor() { | ||
| this.a = new A(); | ||
| >this.a : Symbol(B.a, Decl(privateIdentifierChain.1.ts, 15, 9)) | ||
| >this : Symbol(B, Decl(privateIdentifierChain.1.ts, 13, 1)) | ||
| >a : Symbol(B.a, Decl(privateIdentifierChain.1.ts, 15, 9)) | ||
| >A : Symbol(A, Decl(privateIdentifierChain.1.ts, 0, 0)) | ||
|
|
||
| this.a?.#b; // Error | ||
| >this.a : Symbol(B.a, Decl(privateIdentifierChain.1.ts, 15, 9)) | ||
| >this : Symbol(B, Decl(privateIdentifierChain.1.ts, 13, 1)) | ||
| >a : Symbol(B.a, Decl(privateIdentifierChain.1.ts, 15, 9)) | ||
|
|
||
| this?.a.#b; // Error | ||
| >this?.a : Symbol(B.a, Decl(privateIdentifierChain.1.ts, 15, 9)) | ||
| >this : Symbol(B, Decl(privateIdentifierChain.1.ts, 13, 1)) | ||
| >a : Symbol(B.a, Decl(privateIdentifierChain.1.ts, 15, 9)) | ||
|
|
||
| this?.getA().#b; // Error | ||
| >this?.getA : Symbol(B.getA, Decl(privateIdentifierChain.1.ts, 16, 9)) | ||
| >this : Symbol(B, Decl(privateIdentifierChain.1.ts, 13, 1)) | ||
| >getA : Symbol(B.getA, Decl(privateIdentifierChain.1.ts, 16, 9)) | ||
| } | ||
| } | ||
|
|
136 changes: 136 additions & 0 deletions
136
tests/baselines/reference/privateIdentifierChain.1(target=es2015).types
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,136 @@ | ||
| //// [tests/cases/conformance/expressions/optionalChaining/privateIdentifierChain/privateIdentifierChain.1.ts] //// | ||
|
|
||
| === privateIdentifierChain.1.ts === | ||
| class A { | ||
| >A : A | ||
| > : ^ | ||
|
|
||
| a?: A | ||
| >a : A | undefined | ||
| > : ^^^^^^^^^^^^^ | ||
|
|
||
| #b?: A; | ||
| >#b : A | undefined | ||
| > : ^^^^^^^^^^^^^ | ||
|
|
||
| getA(): A { | ||
| >getA : () => A | ||
| > : ^^^^^^ | ||
|
|
||
| return new A(); | ||
| >new A() : A | ||
| > : ^ | ||
| >A : typeof A | ||
| > : ^^^^^^^^ | ||
| } | ||
| constructor() { | ||
| this.a = this; | ||
| >this.a = this : this | ||
| > : ^^^^ | ||
| >this.a : A | undefined | ||
| > : ^^^^^^^^^^^^^ | ||
| >this : this | ||
| > : ^^^^ | ||
| >a : A | undefined | ||
| > : ^^^^^^^^^^^^^ | ||
| >this : this | ||
| > : ^^^^ | ||
|
|
||
| // None of these should error | ||
| this?.#b; | ||
| >this?.#b : A | undefined | ||
| > : ^^^^^^^^^^^^^ | ||
| >this : this | ||
| > : ^^^^ | ||
|
|
||
| this?.a.#b; | ||
| >this?.a.#b : A | undefined | ||
| > : ^^^^^^^^^^^^^ | ||
| >this?.a : A | ||
| > : ^ | ||
| >this : this | ||
| > : ^^^^ | ||
| >a : A | ||
| > : ^ | ||
|
|
||
| this?.getA().#b; | ||
| >this?.getA().#b : A | undefined | ||
| > : ^^^^^^^^^^^^^ | ||
| >this?.getA() : A | ||
| > : ^ | ||
| >this?.getA : () => A | ||
| > : ^^^^^^ | ||
| >this : this | ||
| > : ^^^^ | ||
| >getA : () => A | ||
| > : ^^^^^^ | ||
| } | ||
| } | ||
|
|
||
| class B { | ||
| >B : B | ||
| > : ^ | ||
|
|
||
| a?: A | ||
| >a : A | undefined | ||
| > : ^^^^^^^^^^^^^ | ||
|
|
||
| getA(): A { | ||
| >getA : () => A | ||
| > : ^^^^^^ | ||
|
|
||
| return new A(); | ||
| >new A() : A | ||
| > : ^ | ||
| >A : typeof A | ||
| > : ^^^^^^^^ | ||
| } | ||
| constructor() { | ||
| this.a = new A(); | ||
| >this.a = new A() : A | ||
| > : ^ | ||
| >this.a : A | undefined | ||
| > : ^^^^^^^^^^^^^ | ||
| >this : this | ||
| > : ^^^^ | ||
| >a : A | undefined | ||
| > : ^^^^^^^^^^^^^ | ||
| >new A() : A | ||
| > : ^ | ||
| >A : typeof A | ||
| > : ^^^^^^^^ | ||
|
|
||
| this.a?.#b; // Error | ||
| >this.a?.#b : any | ||
| > : ^^^ | ||
| >this.a : A | ||
| > : ^ | ||
| >this : this | ||
| > : ^^^^ | ||
| >a : A | ||
| > : ^ | ||
|
|
||
| this?.a.#b; // Error | ||
| >this?.a.#b : any | ||
| > : ^^^ | ||
| >this?.a : A | ||
| > : ^ | ||
| >this : this | ||
| > : ^^^^ | ||
| >a : A | ||
| > : ^ | ||
|
|
||
| this?.getA().#b; // Error | ||
| >this?.getA().#b : any | ||
| > : ^^^ | ||
| >this?.getA() : A | ||
| > : ^ | ||
| >this?.getA : () => A | ||
| > : ^^^^^^ | ||
| >this : this | ||
| > : ^^^^ | ||
| >getA : () => A | ||
| > : ^^^^^^ | ||
| } | ||
| } | ||
|
|
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suspect we need sort of version check to verify that the syntax is available to the syntax we're emitting, like a new grammar check in the checker to verify this.
Unless you're saying that this syntax has always been allowed since feature was standardized?