Skip to content

Allow zero as value to certain tracking parameters#362

Merged
tholu merged 2 commits intomatomo-org:mainfrom
aleximenes:allow-zero-for-certain-tracker-values
Mar 3, 2026
Merged

Allow zero as value to certain tracking parameters#362
tholu merged 2 commits intomatomo-org:mainfrom
aleximenes:allow-zero-for-certain-tracker-values

Conversation

@aleximenes
Copy link
Contributor

Prior to this change, the parameters changed within this commit
did not allow zero as a value as the minimum value they were
compared to was 4.9E-324.

Fixes #361

  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

Prior to this change, the parameters changed within this
commit did not allow zero as a value as the minimum value
they were compared to was 4.9E-324.

Fixes matomo-org#361
@aleximenes
Copy link
Contributor Author

aleximenes commented Oct 1, 2025

Both of the actions fail with the same error:

[2025-09-30 23:23:55] [autobuild] Caused by: org.apache.maven.plugin.compiler.CompilationFailureException: Compilation failure
  [2025-09-30 23:23:55] [autobuild] /home/runner/work/matomo-java-tracker/matomo-java-tracker/servlet-javax/src/test/java/org/matomo/java/tracking/MatomoTrackerFilterIT.java:[35,23] no suitable constructor found for FilterHolder(org.matomo.java.tracking.servlet.MatomoTrackerFilter)

I don't see how this is related to the change that I have made as I have not touched any dependencies. This seems to be related to change with org.eclipse.jetty.ee10.servlet.FilterHolder

See the below line for where it fails:

context.addFilter(new FilterHolder(new MatomoTrackerFilter(tracker)), "/*", null);

It seems that this is related to the update that happened by Dependabot in f2e2da3, where it updated the version of jetty.servlet from 10.0.24 to 11.0.0

….0.24 to 11.0.0 (matomo-org#312)"

This reverts commit f2e2da3.

The change upgraded `matomo-java-tracker-servlet-javax`
to the next version of `jetty-servlet`, which started to use
`jakarta`, making it incompatible with this library.
@aleximenes
Copy link
Contributor Author

As mentioned in the commit, I reverted the change to matomo-java-tracker-servlet-javax where the jetty-servlet version was updated to v11. This is incompatible as it uses jakarta instead of javax.

This should fix the failing builds.

@tholu tholu self-assigned this Mar 3, 2026
@tholu tholu added this to the 3.4.1 milestone Mar 3, 2026
@tholu tholu merged commit 57e40d5 into matomo-org:main Mar 3, 2026
1 check passed
@aleximenes aleximenes deleted the allow-zero-for-certain-tracker-values branch March 3, 2026 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Cannot pass 0 as eventValue

2 participants