[BUG] Cannot pass 0 as eventValue

[micvm]

Describe the bug
I would like to send as event value the value 0, but constraints in the TrackingParameterMethod do not allow that and an Exception fires.

Code snippets

MatomoRequest request = MatomoRequest.request().eventCategory("category").eventAction("action")
						.eventValue(Double.valueOf(0)).build();

Expected behavior
Sending the requests succeeds and an event with eventValue=0 is created on matomo.

Additional context
Exception:

org.matomo.java.tracking.MatomoException: Invalid value for e_v. Must be greater or equal than 4.9E-324
	at org.matomo.java.tracking.TrackingParameterMethod.validateParameterValue(TrackingParameterMethod.java:50)
	at org.matomo.java.tracking.QueryCreator.appendParameter(QueryCreator.java:127)
	... 18 more

[aleximenes]

We are having the same issue regarding some of the other number properties. It seems that the issue stems from the default value of min within the TrackingParameter annotation, seen in

matomo-java-tracker/core/src/main/java/org/matomo/java/tracking/TrackingParameter.java

Lines 22 to 24 in 8dee99e

	double min() default Double.MIN_VALUE;

Double.min is the same as 4.9E-324 (at least in Java 21 version), which causes the default value of min to disallow 0.

There was a commit a few years ago that set the proper min, max values on the TrackingParameter annotation for some fields, see d4f8357.

However, it did not set min and max on the following fields:

• ecommerceRevenue
• eventValue
• ecommerceSubtotal
• ecommerceTax
• ecommerceShippingCost
• ecommerceDiscount

It would be nice to be able to specify 0 on these values.

[aleximenes]

I have created a pull request, #362 , to try to fix this issue as well as fixing the build issues in master. If someone could have a look at that one that would be amazing.

[aleximenes]

@tholu, thanks for merging the related PR and fixing this as it is fixing some issue we are having. Do you know when this will be released as a new version on maven?

[tholu]

@aleximenes I haven't released a new version in a while, is @dheid still around?

[dheid]

@aleximenes I haven't released a new version in a while, is @dheid still around?

Yes, I'm around. Someone kicked me out of the GitHub organization, so I felt excluded from the project. I'm currently working on repairing the release process. Will release the new version soon.

[tholu]

Thank you @dheid ! 👍