Skip to content

Explicitly define mandatory fields of the Deploy object #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rswarbrick wants to merge 1 commit into
base: master
Choose a base branch
from
+9 −0
Open

Explicitly define mandatory fields of the Deploy object #147

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/dvsim/job/deploy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,15 @@ def __init__(self, sim_cfg: "SimCfg") -> None:
# this current job to run
self.needs_all_dependencies_passing = True

# These variables will be extracted from the hjson file by _set_attrs,
# and then _check_attrs checks that they were indeed extracted. Define
# placeholder values here to allow a type checker to know the class has
# the field.
self.build_mode = ""
self.dry_run = False
self.flow_makefile = ""
self.name = ""

# Declare attributes that need to be extracted from the HJSon cfg.
self._define_attrs()

Expand Down
Loading