Explicitly define mandatory fields of the Deploy object#147
Open
rswarbrick wants to merge 1 commit intolowRISC:masterfrom
Open
Explicitly define mandatory fields of the Deploy object#147rswarbrick wants to merge 1 commit intolowRISC:masterfrom
rswarbrick wants to merge 1 commit intolowRISC:masterfrom
Conversation
Signed-off-by: Rupert Swarbrick <rswarbrick@lowrisc.org>
AlexJones0
approved these changes
Apr 2, 2026
Contributor
AlexJones0
left a comment
AlexJones0
left a comment
There was a problem hiding this comment.
Seems reasonable, thanks. In the long term it seems like it would be nice to properly validate everything via e.g. Pydantic models for us, but I suspect we're still a long way away from that with the current FlowCfg and Deploy setup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.