CI: Update / Remove Workflows to Accommodate CalVer#44
Conversation
alexrashed
left a comment
There was a problem hiding this comment.
Thanks a lot for jumping on this! However, I am not so sure if we can already move forward with the cleanup of the "old" labels, which is why I would suggest to split these two concerns (support for calver and cleanup).
There was a problem hiding this comment.
suggestion: I would suggest to separate the two things handled in this PR:
Cleanup workflows that might not be used anymore.
Add support for the new calver labels and their enforcement.
This would help getting the support for calver over the line, while we can discuss if the workflows you would like to clean up really can be removed already.
Same for the changes in .github/workflows/pr-enforce-semver-labels.yml and the README btw.
There was a problem hiding this comment.
Yeah this one was only used by Snowflake - I think depending on what @hovaesco says on this PR and the other PR I think you're right - it might be worth moving this change out and cleaning up the workflows another time just so we can get these changes over the line!
Same with pr-enforce-semver-labels.yml - I believe it's not used by any major repo (only internal repos) but if the final opinion is to not remove this then I can clean this up another time too! 💯
There was a problem hiding this comment.
question: For a (separate) cleanup PR, would it make sense to also remove the semver label definition then?
There was a problem hiding this comment.
Left a comment on the localstack-core PR!
TL;DR I thought it'd be good to keep these since not all our repositories use CalVer and some use SemVer which may want to sync tags (in practice and in hindsight the only repos which do use a labels sync are moving to CalVer but in the future if more repos sync their labels they can opt into using our existing SemVer ones!)
Motivation + Changes
semverrelated workflows since the main repositories which use these (Core, Pro and Snowflake) are moving away from semantic versioning and using calendar versioning instead.calver: monthly,calver: patchandcalver: breaking.pr-enforce-labels->pr-enforce-label-groups(renamed for clarity, updated to use calver instead since everywhere which uses this will migrate to calver)pr-enforce-semver-labels.ymlremoved since it's not used anywherepr-enforce-docs-labels.ymlused in one repo, removing to instead replace withpr-enforce-label-groupspr-enforce-no-major-minor.yml ->pr-enforce-patch-only.yml(updated to support calver too and updated naming to make sense for both)pr-enforce-no-major->pr-enforce-no-breaking-changes(updated to also include thecalver: breakinglabel and renamed for clarity)Additional Changes
Contributes to FLC-256