Skip to content

CI: Update / Remove Workflows to Accommodate CalVer#44

Open
aidehn wants to merge 26 commits intomainfrom
aidehn/feat/calendar-versioning-migrations-and-cleanup
Open

CI: Update / Remove Workflows to Accommodate CalVer#44
aidehn wants to merge 26 commits intomainfrom
aidehn/feat/calendar-versioning-migrations-and-cleanup

Conversation

@aidehn
Copy link

@aidehn aidehn commented Mar 11, 2026

Motivation + Changes

  • This PR cleans up some of the existing semver related workflows since the main repositories which use these (Core, Pro and Snowflake) are moving away from semantic versioning and using calendar versioning instead.
  • These updates involve:
    • Deleting workflows which are no longer needed, renaming workflows to make it clearer what it does and adding new labels for calendar versioning - calver: monthly, calver: patch and calver: breaking.
    • Updating existing workflows to use Calendar Versioning instead of Semantic Versioning
  • Workflow specific changes:
    • pr-enforce-labels -> pr-enforce-label-groups (renamed for clarity, updated to use calver instead since everywhere which uses this will migrate to calver)
    • pr-enforce-semver-labels.yml‎ removed since it's not used anywhere
    • pr-enforce-docs-labels.yml used in one repo, removing to instead replace with pr-enforce-label-groups
    • pr-enforce-no-major-minor.yml‎ -> pr-enforce-patch-only.yml (updated to support calver too and updated naming to make sense for both)
    • pr-enforce-no-major -> pr-enforce-no-breaking-changes (updated to also include the calver: breaking label and renamed for clarity)
  • Updated README.md

Additional Changes

  • PRs were opened in Core, Pro and Snowflake to account for these updates!
  • Changes to internal templates, testing repositories and community have not been made

Contributes to FLC-256

@aidehn aidehn marked this pull request as ready for review March 11, 2026 11:28
@aidehn aidehn changed the title refactor + update feat: update / remove workflows to accommodate calver Mar 11, 2026
@aidehn aidehn changed the title feat: update / remove workflows to accommodate calver CI: Update / Remove Workflows to Accommodate CalVer Mar 11, 2026
@aidehn aidehn requested a review from silv-io March 11, 2026 16:55
@aidehn aidehn requested review from alexrashed and hovaesco March 11, 2026 16:55
Copy link
Member

@alexrashed alexrashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for jumping on this! However, I am not so sure if we can already move forward with the cleanup of the "old" labels, which is why I would suggest to split these two concerns (support for calver and cleanup).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: I would suggest to separate the two things handled in this PR:

Cleanup workflows that might not be used anymore.
Add support for the new calver labels and their enforcement.

This would help getting the support for calver over the line, while we can discuss if the workflows you would like to clean up really can be removed already.
Same for the changes in .github/workflows/pr-enforce-semver-labels.yml and the README btw.

Copy link
Author

@aidehn aidehn Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this one was only used by Snowflake - I think depending on what @hovaesco says on this PR and the other PR I think you're right - it might be worth moving this change out and cleaning up the workflows another time just so we can get these changes over the line!

Same with pr-enforce-semver-labels.yml - I believe it's not used by any major repo (only internal repos) but if the final opinion is to not remove this then I can clean this up another time too! 💯

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: For a (separate) cleanup PR, would it make sense to also remove the semver label definition then?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment on the localstack-core PR!

TL;DR I thought it'd be good to keep these since not all our repositories use CalVer and some use SemVer which may want to sync tags (in practice and in hindsight the only repos which do use a labels sync are moving to CalVer but in the future if more repos sync their labels they can opt into using our existing SemVer ones!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants