-
Notifications
You must be signed in to change notification settings - Fork 158
TPT-4264: Create tests for Create Linodes Options and Password-less #887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -304,3 +304,27 @@ def get_disk_id(test_linode_instance): | |
| ).splitlines() | ||
| first_id = disk_id[0].split(",")[0] | ||
| return first_id | ||
|
|
||
|
|
||
| def wait_for_disk_status( | ||
| linode_id: "str", disk_id: "str", timeout, status: "str", period=10 | ||
| ): | ||
| must_end = time.time() + timeout | ||
| while time.time() < must_end: | ||
| time.sleep(period) | ||
| result = exec_test_command( | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please verify if test pass for you. I get error randomly:
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, it fails so maybe usage of
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm also getting the 404 |
||
| [ | ||
| "linode-cli", | ||
| "linodes", | ||
| "disk-view", | ||
| linode_id, | ||
| disk_id, | ||
| "--format", | ||
| "status", | ||
| "--text", | ||
| "--no-headers", | ||
| ] | ||
| ) | ||
| if status == result: | ||
| return True | ||
| return False | ||
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it not possible to use existing
wait_for_conditioninstead of creating a new method?