TPT-4264: Create tests for Create Linodes Options and Password-less#887
Open
psnoch-akamai wants to merge 2 commits into
Conversation
psnoch-akamai
requested review from
jbilskiAkam and
mawilk90
and removed request for
a team
psnoch-akamai
commented
May 11, 2026
| must_end = time.time() + timeout | ||
| while time.time() < must_end: | ||
| time.sleep(period) | ||
| result = exec_test_command( |
Contributor
Author
There was a problem hiding this comment.
Please verify if test pass for you. I get error randomly:
E Request failed: 404
E Not found
Contributor
There was a problem hiding this comment.
Yes, it fails so maybe usage of wait_for_condition is going to help (as mentioned here)?
Contributor
There was a problem hiding this comment.
I'm also getting the 404
psnoch-akamai
changed the title
Contributor
|
It's worth to mention that using openapi.json from TECH doc PR mentioned in the description will fail with the current linode-cli's parser. Solution provided here |
mawilk90
reviewed
May 12, 2026
|
|
||
|
|
||
| def wait_for_disk_status( | ||
| linode_id: "str", disk_id: "str", timeout, status: "str", period=10 |
Contributor
There was a problem hiding this comment.
Is it not possible to use existing wait_for_condition instead of creating a new method?
…-expand-create-linodes-options-and-password-less
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✔️ How to Test
make test-int TEST_CASE=test_expected_error_if_fields_authorized_users_authorized_keys_root_pass_are_not_set
make test-int TEST_CASE=test_create_linode_with_kernel_and_boot_size_then_add_disk_and_rebuild
TECH doc PR: https://git.source.akamai.com/projects/TECHDOCS/repos/akamai-api-inventory/pull-requests/2685/overview