Add support for C++ modules #1051
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes C++ module support, for users of C++20 and later who prefer to use modules to access the library rather than headers. This feature is enabled by passing
tinyxml2_BUILD_MODULEto CMake, and generates a moduletinyxml2, identical to the namespace. I have further updated the README with additional improvements to formatting (such as highlighted blocks).A previous PR, #1002, proposed C++ modules, however was rejected for including additional build system support beyond CMake (the officially supported build system). It was mentioned that modules are "much more modern" than TinyXML, but this proposal does not increase minimum C++ version required, as the feature is opt-in.