-
Notifications
You must be signed in to change notification settings - Fork 190
Added missing icon exports #1345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
e403fd2
7007736
6cd1998
55dafcd
647ca07
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,13 +1,13 @@ | ||
| import { DEFAULT_HEIGHT, DEFAULT_WIDTH } from '../../constants/constants'; | ||
| import { DARK_PRIMARY_COLOR } from '../../theme'; | ||
| import { IconProps } from '../types'; | ||
| import { CustomIconProps } from '../types'; | ||
|
|
||
| export const ResponseIcon = ({ | ||
| width = DEFAULT_WIDTH, | ||
| height = DEFAULT_HEIGHT, | ||
| primaryFill = DARK_PRIMARY_COLOR, | ||
| ...props | ||
| }: IconProps): JSX.Element => { | ||
| }: CustomIconProps): JSX.Element => { | ||
| return ( | ||
| <svg | ||
| xmlns="http://www.w3.org/2000/svg" | ||
|
|
@@ -79,4 +79,4 @@ export const ResponseIcon = ({ | |
| ); | ||
| }; | ||
|
|
||
| // export default FilterIcon; | ||
| export default ResponseIcon; | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @kishore08-07 this is not needed, because you already exporting from index.ts
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @saurabhraghuvanshii The export default in each icon component (e.g., Responseicon.tsx) is required because the index file uses export { default as ... } from './..'. Removing the default export would break the chain. This is the standard pattern used for all icons in the repo. |
||
kishore08-07 marked this conversation as resolved.
Show resolved
Hide resolved
|
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| export { default as ResponseIcon } from './responseicon'; | ||
| export { default as ResponseIcon } from './Responseicon'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kishore08-07 revert this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@saurabhraghuvanshii Aligned with the existing repo convention, placing {...props} directly on the ensures consistency across all icons.