Conversation
Signed-off-by: kishore08-07 <kishorebsm8@gmail.com>
Signed-off-by: kishore08-07 <kishorebsm8@gmail.com>
There was a problem hiding this comment.
Pull request overview
This PR adds missing icon exports to the icons index file (src/icons/index.ts) to ensure all icon components in the filesystem are properly exported. The PR also fixes a formatting issue and reorganizes exports to maintain strict alphabetical ordering.
Changes:
- Added 16 missing icon exports that existed in the filesystem but were not exported from the index file
- Fixed a formatting issue in the Article export (missing space between
*andfrom) - Reorganized existing exports to maintain strict alphabetical order throughout the file
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: kishore08-07 <kishorebsm8@gmail.com>
|
I can see other file changes ? |
| }; | ||
|
|
||
| // export default FilterIcon; | ||
| export default ResponseIcon; |
There was a problem hiding this comment.
@kishore08-07 this is not needed, because you already exporting from index.ts
There was a problem hiding this comment.
@saurabhraghuvanshii The export default in each icon component (e.g., Responseicon.tsx) is required because the index file uses export { default as ... } from './..'. Removing the default export would break the chain. This is the standard pattern used for all icons in the repo.
| }) => { | ||
| return ( | ||
| <svg width={width} height={height} xmlns="http://www.w3.org/2000/svg" viewBox="0 0 40 40"> | ||
| <svg width={width} height={height} xmlns="http://www.w3.org/2000/svg" viewBox="0 0 40 40" {...props}> |
There was a problem hiding this comment.
@saurabhraghuvanshii Aligned with the existing repo convention, placing {...props} directly on the ensures consistency across all icons.
@Rajesh-Nagarajan-11 Yes, those changes were made to resolve the build errors. |
|
Stale PR. Author abandoned effort? |
@carlosriosilva Apologies for the inactivity, I was away due to some personal issues. |
Signed-off-by: Kishore B <85435355+kishore08-07@users.noreply.github.com>
Signed-off-by: kishore08-07 <kishorebsm8@gmail.com>
Notes for Reviewers
Signed commits