Skip to content

fix: Call identify hooks during init. #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
beekld wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix: Call identify hooks during init. #331

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5581d5e
fix: Call identify hooks during init.
beekld Mar 18, 2026
c9d16b7
remove a commented out line
beekld Mar 19, 2026
a593d1b
fix: call afterIdenfity in the error path
beekld Mar 19, 2026
291c11f
fix: run the identify hooks for each instance, not just the primary one
beekld Mar 20, 2026
12982b5
Merge branch 'main' into beeklimt/SDK-2048
beekld Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 12 additions & 10 deletions ...droid-client-sdk/src/androidTest/java/com/launchdarkly/sdk/android/LDClientHooksTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,11 +61,12 @@ public void executesHooksRegisteredDuringConfiguration() throws Exception {
IdentifySeriesContext identifySeriesContext = new IdentifySeriesContext(newContext, null);
IdentifySeriesResult identifySeriesResult = new IdentifySeriesResult(IdentifySeriesResult.IdentifySeriesStatus.COMPLETED);

assertEquals(1, testHook.beforeIdentifyCalls.size());
assertEquals(identifySeriesContext, testHook.beforeIdentifyCalls.get(0).get("seriesContext"));
assertEquals(1, testHook.afterIdentifyCalls.size());
assertEquals(identifySeriesContext, testHook.afterIdentifyCalls.get(0).get("seriesContext"));
assertEquals(identifySeriesResult, testHook.afterIdentifyCalls.get(0).get("result"));
// index 0 is the implicit identify from init; index 1 is the explicit identify call
assertEquals(2, testHook.beforeIdentifyCalls.size());
assertEquals(identifySeriesContext, testHook.beforeIdentifyCalls.get(1).get("seriesContext"));
assertEquals(2, testHook.afterIdentifyCalls.size());
assertEquals(identifySeriesContext, testHook.afterIdentifyCalls.get(1).get("seriesContext"));
assertEquals(identifySeriesResult, testHook.afterIdentifyCalls.get(1).get("result"));

ldClient.trackMetric("test-event", LDValue.buildObject().put("data", "test").build(), 123.45);

Expand Down Expand Up @@ -149,11 +150,12 @@ public void executesBothInitialHooksAndHooksAddedWithAddHooks() throws Exception
IdentifySeriesContext identifySeriesContext = new IdentifySeriesContext(newContext, null);
IdentifySeriesResult identifySeriesResult = new IdentifySeriesResult(IdentifySeriesResult.IdentifySeriesStatus.COMPLETED);

assertEquals(1, testHook.beforeIdentifyCalls.size());
assertEquals(identifySeriesContext, testHook.beforeIdentifyCalls.get(0).get("seriesContext"));
assertEquals(1, testHook.afterIdentifyCalls.size());
assertEquals(identifySeriesContext, testHook.afterIdentifyCalls.get(0).get("seriesContext"));
assertEquals(identifySeriesResult, testHook.afterIdentifyCalls.get(0).get("result"));
// index 0 is the implicit identify from init; index 1 is the explicit identify call
assertEquals(2, testHook.beforeIdentifyCalls.size());
assertEquals(identifySeriesContext, testHook.beforeIdentifyCalls.get(1).get("seriesContext"));
assertEquals(2, testHook.afterIdentifyCalls.size());
assertEquals(identifySeriesContext, testHook.afterIdentifyCalls.get(1).get("seriesContext"));
assertEquals(identifySeriesResult, testHook.afterIdentifyCalls.get(1).get("result"));

assertEquals(1, addedHook.beforeIdentifyCalls.size());
assertEquals(identifySeriesContext, addedHook.beforeIdentifyCalls.get(0).get("seriesContext"));
Expand Down
3 changes: 3 additions & 0 deletions ...oid-client-sdk/src/androidTest/java/com/launchdarkly/sdk/android/LDClientPluginsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,9 @@ public void registerIsCalledForPlugins() throws Exception {
MockPlugin testPlugin = new MockPlugin(Collections.singletonList(testHook));

try (LDClient ldClient = LDClient.init(application, makeOfflineConfig(List.of(testPlugin)), ldContext, 1)) {
// This should get called because of an implicit identity.
assertEquals(1, testHook.beforeIdentifyCalls.size());

ldClient.boolVariation("test-flag", false);
assertEquals(1, testPlugin.getHooksCalls.size());
assertEquals(1, testPlugin.registerCalls.size());
Expand Down
13 changes: 11 additions & 2 deletions launchdarkly-android-client-sdk/src/main/java/com/launchdarkly/sdk/android/LDClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,23 +249,32 @@ public static Future<LDClient> init(@NonNull Application application,
}

final AtomicInteger initCounter = new AtomicInteger(config.getMobileKeys().size());
Callback<Void> completeWhenCounterZero = new Callback<Void>() {
class CompleteWhenCounterZero implements Callback<Void> {
final private HookRunner.AfterIdentifyMethod afterIdentify;

CompleteWhenCounterZero(HookRunner.AfterIdentifyMethod afterIdentify) {
this.afterIdentify = afterIdentify;
}

@Override
public void onSuccess(Void result) {
afterIdentify.invoke(new IdentifySeriesResult(IdentifySeriesResult.IdentifySeriesStatus.COMPLETED));
if (initCounter.decrementAndGet() == 0) {
resultFuture.set(primaryClient);
}
}

@Override
public void onError(Throwable e) {
afterIdentify.invoke(new IdentifySeriesResult(IdentifySeriesResult.IdentifySeriesStatus.ERROR));
resultFuture.setException(e);
}
};

// Start up all instances
for (final LDClient instance : instances.values()) {
if (instance.connectivityManager.startUp(completeWhenCounterZero)) {
HookRunner.AfterIdentifyMethod afterIdentify = instance.hookRunner.identify(modifiedContext, null);
if (instance.connectivityManager.startUp(new CompleteWhenCounterZero(afterIdentify))) {
instance.eventProcessor.recordIdentifyEvent(modifiedContext);
}
}
Expand Down
Loading