Open
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
launchdarkly-android-client-sdk/src/main/java/com/launchdarkly/sdk/android/LDClient.java
Outdated
Show resolved
Hide resolved
kinyoklion
approved these changes
Mar 19, 2026
Member
kinyoklion
left a comment
There was a problem hiding this comment.
I also agree this is non-breaking. It was the intended behavior, also the primary consumer of this is also us. For our observability plugins.
tanderson-ld
requested changes
Mar 20, 2026
launchdarkly-android-client-sdk/src/main/java/com/launchdarkly/sdk/android/LDClient.java
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Requirements
Related issues
N/A
Describe the solution you've provided
Before this change,
beforeIdentifyandafterIdentifywere only called whenidentifywas called. After this change, they are also called as part ofinit.Describe alternatives you've considered
None.
Additional context
I don't think this would be considered a breaking change, but I wouldn't mind a second opinion. The change in behavior is observable by the user, but the new behavior is what was originally intended. So I would consider this a bugfix, and would not expect customers to need to make any changes to their code to deal with the change.
Note
Medium Risk
Changes initialization behavior to run
beforeIdentify/afterIdentifyhooks duringLDClient.init, which is user-observable and could affect hook implementations that assume identifies only occur on explicit calls. Logic is straightforward but touches the core startup path and error handling.Overview
Calls identify hooks during initialization.
LDClient.initnow starts an implicit identify series viahookRunner.identify(modifiedContext, null)and ensuresafterIdentifyis invoked withCOMPLETEDorERRORwhen each environment finishes (via a newCompleteWhenCounterZerocallback).Updates tests to reflect the new implicit identify. Hook/plugin instrumentation tests now expect an extra identify hook call from init (and adjust assertions/indexing accordingly).
Written by Cursor Bugbot for commit 12982b5. This will update automatically on new commits. Configure here.