fix(CollapsingToolbarBaseActivity): ensure content is scrolled beneath toolbar #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h toolbar Fixes #82. By default, the appbar starts as not lifted, then it's lifted on scroll. That's why the scrollable content is not beneath the toolbar as seen in #82. Our use case doesn't require appbar lifting, so we can safely disable this feature, making the toolbar be permanently lifted above the scrollable content. This would likely be a bug in the material-components library, which doesn't properly handle the edge-to-edge enforcement since Android 15. NOTE: whereas disabling lifting feature fixes the view drawing order (aka Z order), for a better UI, we also need to disable the scrim background animation in Expressive Design (enabled by default since Android 16), otherwise we'll see for a moment the scrollable content through the AppBarLayout. Signed-off-by: iusmac <iusico.maxim@libero.it>
iusmac
force-pushed
the
82-schedule-items-dont-scroll-beneath-toolbar
branch
from
63de0fc to
eecd576
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #82.
By default, the appbar starts as not lifted, then it's lifted on scroll. That's why the scrollable content is not beneath the toolbar as seen in #82. Our use case doesn't require appbar lifting, so we can safely disable this feature, making the toolbar be permanently lifted above the scrollable content.
This would likely be a bug in the material-components library, which doesn't properly handle the edge-to-edge enforcement since Android 15.
NOTE: whereas disabling lifting feature fixes the view drawing order (aka Z order), for a better UI, we also need to disable the scrim background animation in Expressive Design (enabled by default since Android 16), otherwise we'll see for a moment the scrollable content through the AppBarLayout.