Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion source/isaaclab/isaaclab/managers/observation_manager.py
Original file line number Diff line number Diff line change
Expand Up @@ -512,6 +512,7 @@ def _prepare_terms(self):

# read common config for the group
self._group_obs_concatenate[group_name] = group_cfg.concatenate_terms
# to account for the batch dimension
self._group_obs_concatenate_dim[group_name] = (
group_cfg.concatenate_dim + 1 if group_cfg.concatenate_dim >= 0 else group_cfg.concatenate_dim
)
Expand Down Expand Up @@ -550,7 +551,7 @@ def _prepare_terms(self):
if group_cfg.history_length is not None:
term_cfg.history_length = group_cfg.history_length
term_cfg.flatten_history_dim = group_cfg.flatten_history_dim
# add term config to list to list
# add term config to list
self._group_obs_term_names[group_name].append(term_name)
self._group_obs_term_cfgs[group_name].append(term_cfg)

Expand Down Expand Up @@ -604,6 +605,9 @@ def _prepare_terms(self):
f" Received: {mod_cfg.func}"
)

# TODO(jichuanh): improvement can be made in two ways:
# 1. modifier specific check can be done in the modifier class
# 2. general param vs function matching check can be a common utility
Comment thread
AntoineRichard marked this conversation as resolved.
# check if term's arguments are matched by params
term_params = list(mod_cfg.params.keys())
args = inspect.signature(mod_cfg.func).parameters
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,12 @@

from .direct_rl_env_warp import DirectRLEnvWarp # noqa: F401
from .interactive_scene_warp import InteractiveSceneWarp # noqa: F401
from .manager_based_env_warp import ManagerBasedEnvWarp # noqa: F401
from .manager_based_rl_env_warp import ManagerBasedRLEnvWarp # noqa: F401

__all__ = [
"DirectRLEnvWarp",
"InteractiveSceneWarp",
"ManagerBasedEnvWarp",
"ManagerBasedRLEnvWarp",
]
Loading