Adds check script with raycaster attached to H1 robot#4489
Open
pascal-roth wants to merge 3 commits intoisaac-sim:mainfrom
Open
Adds check script with raycaster attached to H1 robot#4489pascal-roth wants to merge 3 commits intoisaac-sim:mainfrom
pascal-roth wants to merge 3 commits intoisaac-sim:mainfrom
Conversation
…#4046) Cleans up new util functions - Bug fix (non-breaking change which fixes an issue) - [ ] I have read and understood the [contribution guidelines](https://isaac-sim.github.io/IsaacLab/main/source/refs/contributing.html) - [ ] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [ ] I have added my name to the `CONTRIBUTORS.md` or my name already exists there --------- Signed-off-by: Mayank Mittal <12863862+Mayankm96@users.noreply.github.com> Co-authored-by: Mayank Mittal <12863862+Mayankm96@users.noreply.github.com>
Contributor
Greptile OverviewGreptile SummaryFixed deprecated PyTorch tensor initialization and migrated codebase from IsaacSim's SimulationContext to IsaacLab's implementation. Added new H1 robot demo with multi-mesh ray caster for testing raycasting with dynamic obstacles. Key Changes:
Issues Found:
Confidence Score: 4/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant User
participant AppLauncher
participant H1Demo
participant ManagerBasedRLEnv
participant SimulationContext
participant Scene
participant MultiMeshRayCaster
participant H1Robot
User->>AppLauncher: Launch with --num_objects arg
AppLauncher->>H1Demo: Initialize H1RoughDemoWithRayCaster
H1Demo->>H1Demo: Load H1RoughEnvCfg_PLAY_WITH_RAYCASTER
Note over H1Demo: Bug: num_obstacles hardcoded to 10<br/>ignores args_cli.num_objects
H1Demo->>H1Demo: Create obstacle configs (0 to num_obstacles)
H1Demo->>H1Demo: Configure MultiMeshRayCasterCfg
Note over H1Demo: Ray caster attached to Robot/torso_link<br/>with 5x5m grid pattern
H1Demo->>ManagerBasedRLEnv: Create environment
ManagerBasedRLEnv->>SimulationContext: Initialize simulation
ManagerBasedRLEnv->>Scene: Setup scene with robot and obstacles
Scene->>H1Robot: Spawn robot at origin
loop For each obstacle
Scene->>Scene: Spawn obstacle_i with random size/position
end
Scene->>MultiMeshRayCaster: Create ray caster sensor
MultiMeshRayCaster->>MultiMeshRayCaster: Setup raycast targets<br/>/World/ground<br/>/World/envs/env_.*/obstacle_.*
H1Demo->>H1Demo: Load pretrained policy
loop Simulation Loop
User->>H1Demo: Step simulation
H1Demo->>H1Robot: Get observations
H1Demo->>H1Demo: Run policy inference
H1Demo->>ManagerBasedRLEnv: Execute actions
ManagerBasedRLEnv->>MultiMeshRayCaster: Update ray caster (50Hz)
MultiMeshRayCaster->>MultiMeshRayCaster: Cast rays in 5x5m grid
MultiMeshRayCaster->>Scene: Detect ground and obstacles
MultiMeshRayCaster-->>H1Demo: Return distance data
end
|
|
|
||
| # Add obstacles individually to the scene | ||
| # Default number of obstacles | ||
| num_obstacles = 10 |
Contributor
There was a problem hiding this comment.
Hardcoded num_obstacles = 10 in __post_init__ ignores the --num_objects CLI argument. The CLI arg on line 34 is parsed but never used.
Suggested change
| num_obstacles = 10 | |
| num_obstacles = args_cli.num_objects if hasattr(args_cli, 'num_objects') else 10 |
Signed-off-by: Mayank Mittal <12863862+Mayankm96@users.noreply.github.com>
Mayankm96
reviewed
Jan 29, 2026
| sim = SimulationContext( | ||
| physics_dt=1.0 / 60.0, rendering_dt=1.0 / 60.0, sim_params=sim_params, backend="torch", device="cuda:0" | ||
| ) | ||
| sim = SimulationContext(SimulationCfg()) |
Contributor
There was a problem hiding this comment.
This needs to be undone. It is isaacsim script.
Mayankm96
approved these changes
Jan 29, 2026
Contributor
Mayankm96
left a comment
There was a problem hiding this comment.
The Isaac Sim script needs to be fixed. Those scripts are minimal repros using Isaac Sim for their team so shouldn't have Isaac Lab code in there.
Other than that, the demo looks pretty cool! <3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes check multi mesh raycaster script and adds additional check script with raycaster attached to H1 robot
Type of change
Screenshots
multi_mesh_ray_caster.mp4
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there